Skip to content

Add HuggingFace Llama3.2 1B to benchmark #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

guangy10
Copy link
Contributor

@guangy10 guangy10 commented Sep 13, 2024

Add llama3.2 1b from Hugging Face to benchmark w/ the following configs:

  • SpinQuant
  • QAT+Lora
  • Original BF16

Switched to use the memory intensive runners in the benchmark workflow to reduce operation cost.

Copy link

pytorch-bot bot commented Sep 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5368

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job

As of commit e2779ee with merge base 8460d42 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2024
@guangy10 guangy10 force-pushed the add_hf_model_to_benchinfra branch 3 times, most recently from 449b4d1 to b48035a Compare September 14, 2024 00:22
@guangy10 guangy10 changed the base branch from gemma_executorch to main September 14, 2024 00:23
@guangy10 guangy10 marked this pull request as ready for review September 14, 2024 00:36
@guangy10 guangy10 force-pushed the add_hf_model_to_benchinfra branch 2 times, most recently from 53e7756 to a13a44b Compare September 14, 2024 00:49
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 force-pushed the add_hf_model_to_benchinfra branch from a13a44b to 97050c2 Compare September 14, 2024 01:34
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10
Copy link
Contributor Author

Upload model artifacts to GitHub is skipped https://github.com/pytorch/executorch/actions/runs/10858058150/job/30136354800. Don't see the reason behind from the log. The model artifacts are placed under artifacts-to-be-uploaded/google/gemma-2b_xnnpack/model.zip @huydhn Any clue why isn't uploaded? IIUC you mentioned any subdirectry under artifacts-to-be-uploaded/ will be uploaded right?

@huydhn
Copy link
Contributor

huydhn commented Sep 14, 2024

Upload model artifacts to GitHub is skipped https://github.com/pytorch/executorch/actions/runs/10858058150/job/30136354800. Don't see the reason behind from the log. The model artifacts are placed under artifacts-to-be-uploaded/google/gemma-2b_xnnpack/model.zip @huydhn Any clue why isn't uploaded? IIUC you mentioned any subdirectry under artifacts-to-be-uploaded/ will be uploaded right?

Oops, the size of the export model is 11+ GB I think. I think uploading such large file to GH is taking too long and the job timed out.

2024-09-14T02:21:26.5056615Z + ls -All ./gemma-2b_xnnpack_fp32.pte
2024-09-14T02:21:26.5057369Z -rw-r--r--. 1 ci-user ci-user 12122356576 Sep 14 01:43 ./gemma-2b_xnnpack_fp32.pte

I think I need to rework the upload part here as GH doesn't scale, so we need to go straight to S3.

@huydhn
Copy link
Contributor

huydhn commented Sep 14, 2024

@guangy10 You could try to rebase the PR now and re-run the test now that #5375 has been merged

@guangy10 guangy10 force-pushed the add_hf_model_to_benchinfra branch 2 times, most recently from cd4c507 to 60b62d3 Compare September 16, 2024 22:28
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 force-pushed the add_hf_model_to_benchinfra branch from 60b62d3 to 009f932 Compare September 17, 2024 18:12
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10
Copy link
Contributor Author

Tried running the gemma-2b on Google Pixel 8 Pro (w/ 12GB RAM). The failure is same. Some I/O failures when connecting the device in the pool: https://github.com/pytorch/executorch/actions/runs/10908663134/job/30277474048. In the stacktrace I see there is a call extra_data_arn = upload_file( trying to upload the extra_data_archive, I'm wondering if it's exceed the set limit because the file is +10GB. cc: @huydhn

@huydhn
Copy link
Contributor

huydhn commented Sep 17, 2024

I'm checking AWS doc on this https://docs.aws.amazon.com/devicefarm/latest/developerguide/limits.html and it mentions a 4GB limit, but that's for the size of the app, not the extra data archive. Let me run this manually using AWS UI and see if it accepts the model.

The archive size is 5.4 GB https://github.com/pytorch/executorch/actions/runs/10908663134/job/30278173066#step:11:38. IIRC, llam2 7b works but it's only ~3GB

@guangy10 guangy10 force-pushed the add_hf_model_to_benchinfra branch 2 times, most recently from 9e89593 to b2d837e Compare September 30, 2024 23:57
@guangy10 guangy10 force-pushed the add_hf_model_to_benchinfra branch from f936584 to 7b55bb9 Compare December 17, 2024 00:34
@guangy10 guangy10 force-pushed the add_hf_model_to_benchinfra branch from 7b55bb9 to 6cb6af9 Compare December 17, 2024 00:36
@guangy10 guangy10 had a problem deploying to upload-benchmark-results December 17, 2024 00:57 — with GitHub Actions Failure
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 17, 2024 01:14 — with GitHub Actions Inactive
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 17, 2024 01:15 — with GitHub Actions Inactive
@guangy10 guangy10 had a problem deploying to upload-benchmark-results December 17, 2024 01:53 — with GitHub Actions Failure
@guangy10 guangy10 had a problem deploying to upload-benchmark-results December 17, 2024 02:55 — with GitHub Actions Failure
@guangy10 guangy10 had a problem deploying to upload-benchmark-results December 17, 2024 03:04 — with GitHub Actions Failure
@guangy10 guangy10 force-pushed the add_hf_model_to_benchinfra branch from cb3efe3 to bedecd8 Compare December 17, 2024 19:19
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 17, 2024 19:53 — with GitHub Actions Inactive
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 17, 2024 19:57 — with GitHub Actions Inactive
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 17, 2024 20:07 — with GitHub Actions Inactive
@guangy10
Copy link
Contributor Author

SpinQuant and QLORA are passing.

@guangy10 guangy10 changed the title Add compatible HuggingFace models to benchmark workflow Add HuggingFace Llama 1B to benchmark Dec 17, 2024
@guangy10 guangy10 changed the title Add HuggingFace Llama 1B to benchmark Add HuggingFace Llama3.2 1B to benchmark Dec 17, 2024
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 17, 2024 21:09 — with GitHub Actions Inactive
@guangy10
Copy link
Contributor Author

@guangy10 guangy10 force-pushed the add_hf_model_to_benchinfra branch from bedecd8 to e2779ee Compare December 17, 2024 23:30
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 added module: benchmark Issues related to the benchmark infrastructure topic: not user facing labels Dec 17, 2024
@guangy10
Copy link
Contributor Author

Decided to leaving the logics of running the 1b model in scheduled jobs in a separate PR to simplify the review as it will require significant refactoring in the workflow.

@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 18, 2024 00:10 — with GitHub Actions Inactive
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 18, 2024 00:12 — with GitHub Actions Inactive
@guangy10 guangy10 temporarily deployed to upload-benchmark-results December 18, 2024 00:23 — with GitHub Actions Inactive
@guangy10 guangy10 merged commit 72bb7b7 into main Dec 18, 2024
104 of 106 checks passed
@guangy10 guangy10 deleted the add_hf_model_to_benchinfra branch December 18, 2024 00:32
@huydhn
Copy link
Contributor

huydhn commented Dec 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: benchmark Issues related to the benchmark infrastructure topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants