[ET-VK][BE][ez] vTensor cleanup 3/N - Introduce conversion operators for vec types
#5423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for `vec` types
## Context
Introduce implicit conversion functions to `vec` types. This allows the following pattern:
```cpp
utils::ivec3 v1{4, 5, 2};
utils::uvec3 v2 = v1;
```
Whereas before, we would have to do
```cpp
utils::ivec3 v1{4, 5, 2};
utils::uvec3 v2(
safe_downcast<uint32_t>(v1[0],
safe_downcast<uint32_t>(v1[1],
safe_downcast<uint32_t>(v1[2]);
```
The connection with `vTensor` class cleanup is that this will allow for consolidation of `vTensor` class methods, specifically circumventing the need to provide two functions to retrieve the logical limits of the `Tensor`, one to retrieve it as a `ivec3` and another to retrieve it as a `uvec3`.
Differential Revision: [D62878650](https://our.internmc.facebook.com/intern/diff/D62878650/)
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5423
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5c5f01a with merge base d2a38cc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62878650 |
This was referenced Sep 17, 2024
Closed
SS-JIA
added a commit
that referenced
this pull request
Sep 17, 2024
…for `vec` types
## Context
Introduce implicit conversion functions to `vec` types. This allows the following pattern:
```cpp
utils::ivec3 v1{4, 5, 2};
utils::uvec3 v2 = v1;
```
Whereas before, we would have to do
```cpp
utils::ivec3 v1{4, 5, 2};
utils::uvec3 v2(
safe_downcast<uint32_t>(v1[0],
safe_downcast<uint32_t>(v1[1],
safe_downcast<uint32_t>(v1[2]);
```
The connection with `vTensor` class cleanup is that this will allow for consolidation of `vTensor` class methods, specifically circumventing the need to provide two functions to retrieve the logical limits of the `Tensor`, one to retrieve it as a `ivec3` and another to retrieve it as a `uvec3`.
Differential Revision: [D62878650](https://our.internmc.facebook.com/intern/diff/D62878650/)
ghstack-source-id: 243061030
Pull Request resolved: #5423
… operators for `vec` types"
## Context
Introduce implicit conversion functions to `vec` types. This allows the following pattern:
```cpp
utils::ivec3 v1{4, 5, 2};
utils::uvec3 v2 = v1;
```
Whereas before, we would have to do
```cpp
utils::ivec3 v1{4, 5, 2};
utils::uvec3 v2(
safe_downcast<uint32_t>(v1[0],
safe_downcast<uint32_t>(v1[1],
safe_downcast<uint32_t>(v1[2]);
```
The connection with `vTensor` class cleanup is that this will allow for consolidation of `vTensor` class methods, specifically circumventing the need to provide two functions to retrieve the logical limits of the `Tensor`, one to retrieve it as a `ivec3` and another to retrieve it as a `uvec3`.
Differential Revision: [D62878650](https://our.internmc.facebook.com/intern/diff/D62878650/)
[ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D62878650 |
jorgep31415
approved these changes
Sep 17, 2024
… operators for `vec` types"
## Context
Introduce implicit conversion functions to `vec` types. This allows the following pattern:
```cpp
utils::ivec3 v1{4, 5, 2};
utils::uvec3 v2 = v1;
```
Whereas before, we would have to do
```cpp
utils::ivec3 v1{4, 5, 2};
utils::uvec3 v2(
safe_downcast<uint32_t>(v1[0],
safe_downcast<uint32_t>(v1[1],
safe_downcast<uint32_t>(v1[2]);
```
The connection with `vTensor` class cleanup is that this will allow for consolidation of `vTensor` class methods, specifically circumventing the need to provide two functions to retrieve the logical limits of the `Tensor`, one to retrieve it as a `ivec3` and another to retrieve it as a `uvec3`.
Differential Revision: [D62878650](https://our.internmc.facebook.com/intern/diff/D62878650/)
[ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D62878650 |
… operators for `vec` types"
## Context
Introduce implicit conversion functions to `vec` types. This allows the following pattern:
```cpp
utils::ivec3 v1{4, 5, 2};
utils::uvec3 v2 = v1;
```
Whereas before, we would have to do
```cpp
utils::ivec3 v1{4, 5, 2};
utils::uvec3 v2(
safe_downcast<uint32_t>(v1[0],
safe_downcast<uint32_t>(v1[1],
safe_downcast<uint32_t>(v1[2]);
```
The connection with `vTensor` class cleanup is that this will allow for consolidation of `vTensor` class methods, specifically circumventing the need to provide two functions to retrieve the logical limits of the `Tensor`, one to retrieve it as a `ivec3` and another to retrieve it as a `uvec3`.
Differential Revision: [D62878650](https://our.internmc.facebook.com/intern/diff/D62878650/)
[ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D62878650 |
|
This pull request has been merged in 958afe1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
vectypes #5423Context
Introduce implicit conversion functions to
vectypes. This allows the following pattern:utils::ivec3 v1{4, 5, 2}; utils::uvec3 v2 = v1;Whereas before, we would have to do
utils::ivec3 v1{4, 5, 2}; utils::uvec3 v2( safe_downcast<uint32_t>(v1[0], safe_downcast<uint32_t>(v1[1], safe_downcast<uint32_t>(v1[2]);The connection with
vTensorclass cleanup is that this will allow for consolidation ofvTensorclass methods, specifically circumventing the need to provide two functions to retrieve the logical limits of theTensor, one to retrieve it as aivec3and another to retrieve it as auvec3.Differential Revision: D62878650