iOS demo app. #557

shoumikhin · 2023-09-30T07:33:38Z

Summary:

Pre-flight:

Clone executorch repo
Install the recommended buck2 binary version at /tmp/buck2
cd path/to/executorch
Sync and update git submodules
Make sure you have Python 3.11+ installed (standard on Ventura+) and pip pointing to it
Run ./install_requirements.sh to install PyTorch dependencies

# Build flatbuffers compiler

cd third-party/flatbuffers && rm -rf cmake-out && mkdir cmake-out && cd cmake-out

cmake .. && cmake --build . --target flatc

cd ../../..

# Configure executorch

rm -rf cmake-out && mkdir cmake-out && cd cmake-out

cmake .. -G Xcode -DCMAKE_TOOLCHAIN_FILE=../third-party/pytorch/cmake/iOS.cmake -DBUCK2=/tmp/buck2 -DPYTHON_EXECUTABLE=$(which python3) -DFLATC_EXECUTABLE=$(realpath ../third-party/flatbuffers/cmake-out/flatc) -DCMAKE_ARCHIVE_OUTPUT_DIRECTORY=$(pwd) -DEXECUTORCH_BUILD_XNNPACK=ON -DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON -DCMAKE_XCODE_ATTRIBUTE_DEVELOPMENT_TEAM=<YOUR_TEAM_ID>  # -DPLATFORM=SIMULATOR

# Build executorch

cmake --build . --config Release

# Copy executorch libs

cd Release

mkdir -p ../../examples/ios_demo_apps/ExecuTorchDemo/ExecuTorchDemo/Frameworks/executorch/

cp libclog.a libcpuinfo.a libexecutorch.a libextension_data_loader.a libportable_kernels.a libportable_ops_lib.a libpthreadpool.a libxnnpack_backend.a libXNNPACK.a ../../examples/ios_demo_apps/ExecuTorchDemo/ExecuTorchDemo/Frameworks/executorch/

cd ../..

# Download the labels and bundle with the app

mkdir -p examples/ios_demo_apps/ExecuTorchDemo/ExecuTorchDemo/Resources/Models/MobileNet/

curl https://raw.githubusercontent.com/pytorch/hub/master/imagenet_classes.txt -o examples/ios_demo_apps/ExecuTorchDemo/ExecuTorchDemo/Resources/Models/MobileNet/imagenet_classes.txt

# Export a MobileNet v3 model backed with XNNPACK delegate and copy it over to bundle with the app

export FLATC_EXECUTABLE=$(realpath third-party/flatbuffers/cmake-out/flatc)

python3 -m examples.export.export_example --model_name="mv3"
python3 -m examples.backend.xnnpack_examples --model_name="mv3" --delegate

cp mv3.pte mv3_xnnpack_fp32.pte examples/ios_demo_apps/ExecuTorchDemo/ExecuTorchDemo/Resources/Models/MobileNet/

Post-flight:

Open executorch/examples/ios_demo_apps/ExecuTorchDemo/ExecuTorchDemo.xcodeproj
Set the header search path for MobileNetClassifier target pointing to the dir containing the executorch repo
Run the app and tests

Differential Revision: D49800418

netlify · 2023-09-30T07:33:44Z

✅ Deploy Preview for resplendent-gnome-14e531 canceled.

Name	Link
🔨 Latest commit	`b303e6d`
🔍 Latest deploy log	https://app.netlify.com/sites/resplendent-gnome-14e531/deploys/651ba5310c704f00087e5473

facebook-github-bot · 2023-09-30T07:34:10Z

This pull request was exported from Phabricator. Differential Revision: D49800418

kimishpatel

for model files bundled here, I am gonna suggest to have a python script that generates this files and link them as steps in the tutorial:
e.g.

python generate_mv2.py --delegate...
copy the pte file to
..

kimishpatel · 2023-10-02T16:11:06Z

examples/ios_demo_apps/ExecuTorchDemo/ExecuTorchDemo.xcodeproj/project.pbxproj

+			isa = PBXFrameworksBuildPhase;
+			buildActionMask = 2147483647;
+			files = (
+				03C818472AC7A1190084CC29 /* libImageClassification.a in Frameworks */,


what are the ids? and how are they connect to libs

These are not related, they are part of the xcode project, which is currently hardcoded, but we'll generate it eventually and get rid of this file.

kimishpatel

sending it back for 2 things

if we can make model generation as part of the script that should be invoked, that would be good.
documentation as to how to enable your own delegate. this will help apple

...ples/ios_demo_apps/ExecuTorchDemo/ExecuTorchDemo/Sources/MobileNet/MobileNetClassifier.swift

cccclai · 2023-10-02T16:29:57Z

examples/ios_demo_apps/ExecuTorchDemo/ExecuTorchDemo/Sources/MobileNet/Module.h

+  std::vector<torch::executor::Span<uint8_t>> plannedSpans_;
+  std::unique_ptr<torch::executor::HierarchicalAllocator> plannedMemory_;
+  std::unique_ptr<torch::executor::MemoryManager> memoryManager_;
+  std::unique_ptr<torch::executor::Method> forward_;


maybe call it method_ for consistency

examples/ios_demo_apps/ExecuTorchDemo/ExecuTorchDemo/Sources/MobileNet/Module.cpp

...ples/ios_demo_apps/ExecuTorchDemo/ExecuTorchDemo/Sources/MobileNet/MobileNetClassifier.swift

examples/ios_demo_apps/ExecuTorchDemo/ExecuTorchDemo/Sources/MobileNet/MobileNetClassifier.mm

examples/ios_demo_apps/ExecuTorchDemo/ExecuTorchDemo/Sources/MobileNet/Module.cpp

facebook-github-bot · 2023-10-02T23:47:51Z

This pull request was exported from Phabricator. Differential Revision: D49800418

facebook-github-bot · 2023-10-02T23:51:46Z

This pull request was exported from Phabricator. Differential Revision: D49800418

kimishpatel · 2023-10-02T23:55:25Z

for ios toolchain for cmake, I think we should standardize it. Apple's PR also has sometihng like that but it is part of their PR

facebook-github-bot · 2023-10-03T00:03:54Z

This pull request was exported from Phabricator. Differential Revision: D49800418

facebook-github-bot · 2023-10-03T00:10:51Z

This pull request was exported from Phabricator. Differential Revision: D49800418

facebook-github-bot · 2023-10-03T00:17:09Z

This pull request was exported from Phabricator. Differential Revision: D49800418

shoumikhin · 2023-10-03T00:17:19Z

for ios toolchain for cmake, I think we should standardize it. Apple's PR also has sometihng like that but it is part of their PR

They should be able to use ours, as shown in PR summary

facebook-github-bot · 2023-10-03T00:22:29Z

This pull request was exported from Phabricator. Differential Revision: D49800418

facebook-github-bot · 2023-10-03T01:13:43Z

This pull request was exported from Phabricator. Differential Revision: D49800418

facebook-github-bot · 2023-10-03T01:38:23Z

This pull request was exported from Phabricator. Differential Revision: D49800418

facebook-github-bot · 2023-10-03T01:43:23Z

This pull request was exported from Phabricator. Differential Revision: D49800418

facebook-github-bot · 2023-10-03T01:48:36Z

This pull request was exported from Phabricator. Differential Revision: D49800418

facebook-github-bot · 2023-10-03T05:18:02Z

This pull request was exported from Phabricator. Differential Revision: D49800418

Summary: Pull Request resolved: #557 Reviewed By: cccclai Differential Revision: D49800418 fbshipit-source-id: c4233781166453bca131c5fe0c2d76ad60f20448

facebook-github-bot · 2023-10-03T05:22:49Z

This pull request was exported from Phabricator. Differential Revision: D49800418

facebook-github-bot · 2023-10-03T10:40:59Z

This pull request has been merged in f9e23ea.

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2023

facebook-github-bot added the fb-exported label Sep 30, 2023

kimishpatel reviewed Oct 2, 2023

View reviewed changes

kimishpatel requested changes Oct 2, 2023

View reviewed changes

cccclai reviewed Oct 2, 2023

View reviewed changes

kimishpatel approved these changes Oct 3, 2023

View reviewed changes

iOS demo app. (#557)

b303e6d

Summary: Pull Request resolved: #557 Reviewed By: cccclai Differential Revision: D49800418 fbshipit-source-id: c4233781166453bca131c5fe0c2d76ad60f20448

facebook-github-bot closed this in f9e23ea Oct 3, 2023

facebook-github-bot added the Merged label Oct 3, 2023

iOS demo app. #557

iOS demo app. #557

Uh oh!

Conversation

shoumikhin commented Sep 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Sep 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for resplendent-gnome-14e531 canceled.

Uh oh!

facebook-github-bot commented Sep 30, 2023

Uh oh!

kimishpatel left a comment

Choose a reason for hiding this comment

Uh oh!

kimishpatel Oct 2, 2023

Choose a reason for hiding this comment

Uh oh!

shoumikhin Oct 2, 2023

Choose a reason for hiding this comment

Uh oh!

kimishpatel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cccclai Oct 2, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented Oct 2, 2023

Uh oh!

facebook-github-bot commented Oct 2, 2023

Uh oh!

kimishpatel commented Oct 2, 2023

Uh oh!

facebook-github-bot commented Oct 3, 2023

Uh oh!

facebook-github-bot commented Oct 3, 2023

Uh oh!

facebook-github-bot commented Oct 3, 2023

Uh oh!

shoumikhin commented Oct 3, 2023

Uh oh!

facebook-github-bot commented Oct 3, 2023

Uh oh!

facebook-github-bot commented Oct 3, 2023

Uh oh!

facebook-github-bot commented Oct 3, 2023

Uh oh!

facebook-github-bot commented Oct 3, 2023

Uh oh!

facebook-github-bot commented Oct 3, 2023

Uh oh!

facebook-github-bot commented Oct 3, 2023

Uh oh!

facebook-github-bot commented Oct 3, 2023

Uh oh!

facebook-github-bot commented Oct 3, 2023

Uh oh!

Uh oh!

shoumikhin commented Sep 30, 2023 •

edited

Loading

netlify bot commented Sep 30, 2023 •

edited

Loading