op_clamp: add downcasting tests & fix #5798
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed By: swolchok Differential Revision: D63716405
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5798
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b5a81fa with merge base fbcd332 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63716405 |
swolchok
approved these changes
Oct 1, 2024
|
This pull request has been merged in 3aa6b14. |
|
@pytorchbot cherry-pick --onto release/0.4 -c release |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 10, 2024
Cherry picking #5798The cherry pick PR is at #6131 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Oct 11, 2024
op_clamp: add downcasting tests & fix (#5798) Summary: Pull Request resolved: #5798 Reviewed By: swolchok Differential Revision: D63716405 fbshipit-source-id: 4987e9ad93f0b3f490432cf07ba19c2f26fc82e0 (cherry picked from commit 3aa6b14) Co-authored-by: Manuel Candales <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed By: swolchok
Differential Revision: D63716405