Skip to content

Allow int8 type in quantized_layer_norm #5899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

mcremon-meta
Copy link
Contributor

Summary: The meta kernel was returning uint8 as a hardcoded value.

Differential Revision: D63659948

Copy link

pytorch-bot bot commented Oct 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5899

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ac3d38d with merge base 28c9548 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63659948

facebook-github-bot pushed a commit that referenced this pull request Oct 4, 2024
Summary:

The meta kernel was returning uint8 as a hardcoded value.

Differential Revision: D63659948
mcremon-meta added a commit that referenced this pull request Oct 7, 2024
Summary:

The meta kernel was returning uint8 as a hardcoded value.

Differential Revision: D63659948
mcremon-meta added a commit that referenced this pull request Oct 8, 2024
Summary:

The meta kernel was returning uint8 as a hardcoded value.

Reviewed By: zonglinpeng

Differential Revision: D63659948
mcremon-meta added a commit that referenced this pull request Oct 8, 2024
Summary:

The meta kernel was returning uint8 as a hardcoded value.

Reviewed By: zonglinpeng

Differential Revision: D63659948
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63659948

Summary:

As titled.

Reviewed By: zonglinpeng

Differential Revision: D63659947
Summary:

The meta kernel was returning uint8 as a hardcoded value.

Reviewed By: zonglinpeng

Differential Revision: D63659948
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63659948

facebook-github-bot pushed a commit that referenced this pull request Oct 9, 2024
Summary:

The meta kernel was returning uint8 as a hardcoded value.

Reviewed By: zonglinpeng

Differential Revision: D63659948
facebook-github-bot pushed a commit that referenced this pull request Oct 9, 2024
Summary:

The meta kernel was returning uint8 as a hardcoded value.

Reviewed By: zonglinpeng

Differential Revision: D63659948
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f5f6969.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants