Migrate backends/arm to the new namespace #5904
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5904
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 4ea2808 with merge base 6e871c3 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63923290 |
zingo
added
partner: arm
|
PR seem to miss a fix here |
Summary: Move the Arm backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces. Also, move the VelaBinStream code into a namespace to avoid declaring symbols in the global namespace. Reviewed By: mergennachin Differential Revision: D63923290
dbort
force-pushed
the
export-D63923290
branch
from
09f9a61 to
4ea2808
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63923290 |
|
@zingo Thanks; I just pushed a new version that fixes that issue, and I verified it locally. |
|
This pull request has been merged in 03e4516. |
|
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
Summary: Pull Request resolved: #5904 Move the Arm backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces. Also, move the VelaBinStream code into a namespace to avoid declaring symbols in the global namespace. Reviewed By: mergennachin Differential Revision: D63923290 fbshipit-source-id: a98e4c1ede8072a9fd96fb7fc2e2fcc4e82bc28a (cherry picked from commit 03e4516)
Cherry picking #5904The cherry pick PR is at #5974 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
|
This is already closed but If the CI was happy when adding trunk builds I'm also happy, thanks for fixing this before merging. |
Migrate backends/arm to the new namespace (#5904) Summary: Pull Request resolved: #5904 Move the Arm backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces. Also, move the VelaBinStream code into a namespace to avoid declaring symbols in the global namespace. Reviewed By: mergennachin Differential Revision: D63923290 fbshipit-source-id: a98e4c1ede8072a9fd96fb7fc2e2fcc4e82bc28a (cherry picked from commit 03e4516) Co-authored-by: Dave Bort <[email protected]>
Summary:
Move the Arm backend out of the
torch::namespace, and update to avoid using thetorch::orexec_aten::namespaces.Also, move the VelaBinStream code into a namespace to avoid declaring symbols in the global namespace.
Differential Revision: D63923290