Move vulkan.passes to vulkan._passes #5919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

tarun292 wants to merge 1 commit into main from export-D63926849

Contributor

tarun292 commented Oct 6, 2024

Differential Revision: D63926849

pytorch-bot bot commented Oct 6, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5919

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 978077a with merge base da1d2ca ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/periodic module: vulkan labels

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Oct 6, 2024

This pull request was exported from Phabricator. Differential Revision: D63926849

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63926849

tarun292 added a commit that referenced this pull request


          Move vulkan.passes to vulkan._passes (#5919)

686125d

Summary:
Changing vulkan.passes to vulkan._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5919

Differential Revision: D63926849

tarun292 force-pushed the export-D63926849 branch from 5fffedd to 686125d Compare

October 7, 2024 15:12

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63926849

tarun292 added a commit that referenced this pull request


          Move vulkan.passes to vulkan._passes (#5919)

469a979

Summary:
Changing vulkan.passes to vulkan._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5919

Differential Revision: D63926849

tarun292 force-pushed the export-D63926849 branch from 686125d to 469a979 Compare

October 7, 2024 15:20

helunwencser approved these changes

View reviewed changes

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63926849

tarun292 added a commit that referenced this pull request


          Move vulkan.passes to vulkan._passes (#5919)

bd83f5d

Summary:
Changing vulkan.passes to vulkan._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5919

Reviewed By: helunwencser

Differential Revision: D63926849

tarun292 force-pushed the export-D63926849 branch from 469a979 to bd83f5d Compare

October 7, 2024 20:08

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63926849

tarun292 added a commit that referenced this pull request


          Move vulkan.passes to vulkan._passes (#5919)

6328e05

Summary:
Changing vulkan.passes to vulkan._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5919

Reviewed By: helunwencser

Differential Revision: D63926849

tarun292 force-pushed the export-D63926849 branch from bd83f5d to 6328e05 Compare

October 7, 2024 20:15

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63926849

tarun292 added a commit that referenced this pull request


          Move vulkan.passes to vulkan._passes (#5919)

749086d

Summary:
Changing vulkan.passes to vulkan._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5919

Reviewed By: helunwencser

Differential Revision: D63926849

tarun292 force-pushed the export-D63926849 branch from 6328e05 to 749086d Compare

October 7, 2024 23:19

tarun292 added a commit that referenced this pull request


          Move vulkan.passes to vulkan._passes (#5919)

2227c4a

Summary:
Changing vulkan.passes to vulkan._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5919

Reviewed By: helunwencser

Differential Revision: D63926849

tarun292 force-pushed the export-D63926849 branch from 749086d to 2227c4a Compare

October 8, 2024 16:30

Contributor

facebook-github-bot commented Oct 8, 2024

This pull request was exported from Phabricator. Differential Revision: D63926849

1 similar comment

Contributor

facebook-github-bot commented Oct 8, 2024

This pull request was exported from Phabricator. Differential Revision: D63926849

tarun292 added a commit that referenced this pull request


          Move vulkan.passes to vulkan._passes (#5919)

eea13e1

Summary:
Changing vulkan.passes to vulkan._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5919

Reviewed By: helunwencser

Differential Revision: D63926849

tarun292 force-pushed the export-D63926849 branch from 2227c4a to eea13e1 Compare

October 8, 2024 20:18

Contributor

facebook-github-bot commented Oct 8, 2024

This pull request was exported from Phabricator. Differential Revision: D63926849

tarun292 added a commit that referenced this pull request


          Move vulkan.passes to vulkan._passes (#5919)

2a7a83d

Summary:
Changing vulkan.passes to vulkan._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5919

Reviewed By: helunwencser

Differential Revision: D63926849

tarun292 force-pushed the export-D63926849 branch from eea13e1 to 2a7a83d Compare

October 8, 2024 20:26

tarun292 added a commit that referenced this pull request


          Move vulkan.passes to vulkan._passes (#5919)

75fbbd6

Summary:
Changing vulkan.passes to vulkan._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5919

Reviewed By: helunwencser

Differential Revision: D63926849

tarun292 force-pushed the export-D63926849 branch from 2a7a83d to 75fbbd6 Compare

October 8, 2024 23:04

Contributor

facebook-github-bot commented Oct 8, 2024

This pull request was exported from Phabricator. Differential Revision: D63926849

1 similar comment

Contributor

facebook-github-bot commented Oct 8, 2024

This pull request was exported from Phabricator. Differential Revision: D63926849

tarun292 added a commit that referenced this pull request


          Move vulkan.passes to vulkan._passes (#5919)

b5eafb1

Summary:
Changing vulkan.passes to vulkan._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5919

Reviewed By: helunwencser

Differential Revision: D63926849

tarun292 force-pushed the export-D63926849 branch from 75fbbd6 to b5eafb1 Compare

October 8, 2024 23:10

Contributor

facebook-github-bot commented Oct 9, 2024

This pull request was exported from Phabricator. Differential Revision: D63926849

tarun292 added a commit that referenced this pull request


          Move vulkan.passes to vulkan._passes (#5919)

0da154c

Summary:
Changing vulkan.passes to vulkan._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5919

Reviewed By: helunwencser

Differential Revision: D63926849

tarun292 force-pushed the export-D63926849 branch from b5eafb1 to 0da154c Compare

October 9, 2024 08:46


          Move vulkan.passes to vulkan._passes (#5919)

978077a

Summary:
Changing vulkan.passes to vulkan._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5919

Reviewed By: helunwencser

Differential Revision: D63926849

Contributor

facebook-github-bot commented Oct 9, 2024

This pull request was exported from Phabricator. Differential Revision: D63926849

tarun292 force-pushed the export-D63926849 branch from 0da154c to 978077a Compare

October 9, 2024 08:51

facebook-github-bot closed this in

e1832ef

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Oct 9, 2024

This pull request has been merged in e1832ef.

Contributor Author

tarun292 commented Oct 10, 2024

@pytorchbot cherry-pick --onto release/0.4 -c critical

Collaborator

pytorchbot commented Oct 10, 2024

Cherry picking #5919

Command git -C /home/runner/work/executorch/executorch cherry-pick -x -X theirs e1832efa5544438cbcd981d43c6a10f254ecdafb returned non-zero exit code 1

CONFLICT (modify/delete): backends/transforms/targets.bzl deleted in HEAD and modified in e1832efa5 (Move vulkan.passes to vulkan._passes (#5919)).  Version e1832efa5 (Move vulkan.passes to vulkan._passes (#5919)) of backends/transforms/targets.bzl left in tree.
Auto-merging backends/vulkan/TARGETS
CONFLICT (rename/delete): backends/vulkan/passes/remove_local_scalar_dense_ops.py renamed to backends/vulkan/_passes/remove_local_scalar_dense_ops.py in e1832efa5 (Move vulkan.passes to vulkan._passes (#5919)), but deleted in HEAD.
Auto-merging backends/vulkan/partitioner/supported_ops.py
Auto-merging backends/vulkan/vulkan_preprocess.py
error: could not apply e1832efa5... Move vulkan.passes to vulkan._passes (#5919)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

tarun292 added a commit that referenced this pull request


          Move vulkan.passes to vulkan._passes (#5919)

Summary:
Changing vulkan.passes to vulkan._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5919

Reviewed By: helunwencser

Differential Revision: D63926849

fbshipit-source-id: bf135c46c6718bc37afa640cf51d004891516575
(cherry picked from commit e1832ef)

This was referenced Oct 10, 2024

Move vulkan.passes to vulkan._passes (#5919) #6129

Merged

[v0.4.0] Release Tracker #5366

Closed

jackzhxng pushed a commit that referenced this pull request


          Move vulkan.passes to vulkan._passes (#5919) (#6129)

905a26f

Summary:
Changing vulkan.passes to vulkan._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5919

Reviewed By: helunwencser

Differential Revision: D63926849

fbshipit-source-id: bf135c46c6718bc37afa640cf51d004891516575
(cherry picked from commit e1832ef)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/periodic CLA Signed fb-exported Merged module: vulkan