Skip to content

Qualcomm AI Engine Direct - Fixed layer norm quantization annotation for 16bit #5927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Qualcomm AI Engine Direct - Fixed layer norm quantization annotation for 16bit #5927

wants to merge 1 commit into from

Conversation

shewu-quic
Copy link
Collaborator

  • Fixed quantization annotation for layer norm in 16bit.
  • Add a unit test for 16a4w layer norm.

@shewu-quic
Qualcomm AI Engine Direct - Fixed layer norm quantization annotation …
82798df 
…for 16bit

- Fixed quantization annotation for layer norm in 16bit.
- Add a unit test for 16a4w layer norm.
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5927

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 82798df with merge base c06a708 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2024
@shewu-quic shewu-quic mentioned this pull request Oct 7, 2024
Open
cccclai
cccclai approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending the fix and adding the unit test.

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cccclai merged this pull request in 2eb6b04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shewu-quic @facebook-github-bot @cccclai