Skip to content

Move benchmark apps to extension/benchmark dir #5951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Move benchmark apps to extension/benchmark dir #5951

wants to merge 1 commit into from

Conversation

guangy10
Copy link
Contributor

@guangy10 guangy10 commented Oct 7, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5951

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5f1862b with merge base 9c4032b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2024
@guangy10 guangy10 force-pushed the move_benchmark_apps branch from ebff220 to adf9908 Compare October 7, 2024 21:51
@guangy10
Copy link
Contributor Author

guangy10 commented Oct 7, 2024

Resolve linter errors by adding the .clang-format for apple code.

@guangy10 guangy10 had a problem deploying to upload-benchmark-results October 7, 2024 22:21 — with GitHub Actions Failure
@guangy10 guangy10 temporarily deployed to upload-benchmark-results October 7, 2024 22:35 — with GitHub Actions Inactive
@guangy10 guangy10 force-pushed the move_benchmark_apps branch from adf9908 to 886165b Compare October 7, 2024 23:06
@guangy10
Copy link
Contributor Author

guangy10 commented Oct 7, 2024

Fixed validate-android-test-spec. The job name "Upload AWS Device Farm Android test specs" must be passed as a str.

@guangy10 guangy10 marked this pull request as ready for review October 7, 2024 23:12
@guangy10 guangy10 requested review from shoumikhin and huydhn October 7, 2024 23:12
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 temporarily deployed to upload-benchmark-results October 7, 2024 23:38 — with GitHub Actions Inactive
huydhn
huydhn approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped!

@guangy10 guangy10 temporarily deployed to upload-benchmark-results October 7, 2024 23:39 — with GitHub Actions Inactive
@guangy10 guangy10 force-pushed the move_benchmark_apps branch from 886165b to d13b55d Compare October 7, 2024 23:49
@guangy10
Copy link
Contributor Author

guangy10 commented Oct 7, 2024

More fixes in the extension/benchmark/apple/Benchmark/README.md

guangy10
guangy10 commented Oct 7, 2024
View reviewed changes
@guangy10 guangy10 force-pushed the move_benchmark_apps branch from d13b55d to bd31977 Compare October 8, 2024 00:07
guangy10
guangy10 commented Oct 8, 2024
View reviewed changes
@guangy10 guangy10 force-pushed the move_benchmark_apps branch from bd31977 to 5f1862b Compare October 8, 2024 00:27
@guangy10
Copy link
Contributor Author

guangy10 commented Oct 8, 2024

More relative paths fix in Benchmark.xcodeproj/project.pbxproj

@guangy10 guangy10 temporarily deployed to upload-benchmark-results October 8, 2024 01:00 — with GitHub Actions Inactive
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 temporarily deployed to upload-benchmark-results October 8, 2024 02:29 — with GitHub Actions Inactive
@facebook-github-bot
Copy link
Contributor

@guangy10 merged this pull request in ac2ae07.

@guangy10
Copy link
Contributor Author

guangy10 commented Oct 8, 2024

@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Oct 8, 2024
@pytorchbot
Move benchmark apps to extension/benchmark dir (#5951)
91d6452 
Summary: Pull Request resolved: #5951

Reviewed By: huydhn

Differential Revision: D64012575

Pulled By: guangy10

fbshipit-source-id: 27bb25586af2aafb8df6c0623d502482b4fa238b
(cherry picked from commit ac2ae07)
@pytorchbot
Copy link
Collaborator

Cherry picking #5951

The cherry pick PR is at #5971 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guangy10 @facebook-github-bot @pytorchbot @shoumikhin @huydhn