filter gif from lint rules #5995
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
when running `lintrunner -a`, it shows
```
(executorch) chenlai@chenlai-mbp executorch % lintrunner -a
Warning: Could not find a lintrunner config at: '.lintrunner.private.toml'. Continuing without using configuration file.
UFMT success!
CLANGFORMAT success!
FLAKE8 success!
NEWLINE failure
CMAKE success!
ETCAPITAL success!
>>> Lint for examples/models/llama2/Android3_2_1B_bf16.gif:
Error (NEWLINE) Decoding failure
utf-8 decoding failed due to UnicodeDecodeError:
'utf-8' codec can't decode byte 0xf7 in position 10: invalid start byte
>>> Lint for examples/models/llama2/Android3_2_3B_SpinQuant.gif:
Error (NEWLINE) Decoding failure
utf-8 decoding failed due to UnicodeDecodeError:
'utf-8' codec can't decode byte 0xf7 in position 10: invalid start byte
>>> Lint for examples/models/llama2/llama_via_xnnpack.gif:
Error (NEWLINE) Decoding failure
utf-8 decoding failed due to UnicodeDecodeError:
'utf-8' codec can't decode byte 0xf7 in position 10: invalid start byte
>>> Lint for examples/models/llava/llava_via_xnnpack.gif:
Error (NEWLINE) Decoding failure
utf-8 decoding failed due to UnicodeDecodeError:
'utf-8' codec can't decode byte 0xd0 in position 6: invalid continuation
byte
Successfully applied all patches.
```
Thanks kirklandsign for identifying the root cause!
Differential Revision: D64059251
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5995
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5e72cf9 with merge base f0112a2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64059251 |
kirklandsign
approved these changes
Oct 8, 2024
|
This pull request has been merged in fe083e5. |
|
@pytorchbot cherry-pick --onto release/0.4 -c regression |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 8, 2024
Summary: Pull Request resolved: #5995 when running `lintrunner -a`, it shows ``` (executorch) chenlai@chenlai-mbp executorch % lintrunner -a Warning: Could not find a lintrunner config at: '.lintrunner.private.toml'. Continuing without using configuration file. UFMT success! CLANGFORMAT success! FLAKE8 success! NEWLINE failure CMAKE success! ETCAPITAL success! >>> Lint for examples/models/llama2/Android3_2_1B_bf16.gif: Error (NEWLINE) Decoding failure utf-8 decoding failed due to UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf7 in position 10: invalid start byte >>> Lint for examples/models/llama2/Android3_2_3B_SpinQuant.gif: Error (NEWLINE) Decoding failure utf-8 decoding failed due to UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf7 in position 10: invalid start byte >>> Lint for examples/models/llama2/llama_via_xnnpack.gif: Error (NEWLINE) Decoding failure utf-8 decoding failed due to UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf7 in position 10: invalid start byte >>> Lint for examples/models/llava/llava_via_xnnpack.gif: Error (NEWLINE) Decoding failure utf-8 decoding failed due to UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd0 in position 6: invalid continuation byte Successfully applied all patches. ``` Thanks kirklandsign for identifying the root cause! Reviewed By: kirklandsign Differential Revision: D64059251 fbshipit-source-id: 6960ea7eb8108c622cf33870258bbe3da741e27e (cherry picked from commit fe083e5)
Cherry picking #5995The cherry pick PR is at #6002 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Oct 9, 2024
filter gif from lint rules (#5995) Summary: Pull Request resolved: #5995 when running `lintrunner -a`, it shows ``` (executorch) chenlai@chenlai-mbp executorch % lintrunner -a Warning: Could not find a lintrunner config at: '.lintrunner.private.toml'. Continuing without using configuration file. UFMT success! CLANGFORMAT success! FLAKE8 success! NEWLINE failure CMAKE success! ETCAPITAL success! >>> Lint for examples/models/llama2/Android3_2_1B_bf16.gif: Error (NEWLINE) Decoding failure utf-8 decoding failed due to UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf7 in position 10: invalid start byte >>> Lint for examples/models/llama2/Android3_2_3B_SpinQuant.gif: Error (NEWLINE) Decoding failure utf-8 decoding failed due to UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf7 in position 10: invalid start byte >>> Lint for examples/models/llama2/llama_via_xnnpack.gif: Error (NEWLINE) Decoding failure utf-8 decoding failed due to UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf7 in position 10: invalid start byte >>> Lint for examples/models/llava/llava_via_xnnpack.gif: Error (NEWLINE) Decoding failure utf-8 decoding failed due to UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd0 in position 6: invalid continuation byte Successfully applied all patches. ``` Thanks kirklandsign for identifying the root cause! Reviewed By: kirklandsign Differential Revision: D64059251 fbshipit-source-id: 6960ea7eb8108c622cf33870258bbe3da741e27e (cherry picked from commit fe083e5) Co-authored-by: Chen Lai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
when running
lintrunner -a, it showsThanks kirklandsign for identifying the root cause!
Differential Revision: D64059251