Skip to content

Migrate backends/qualcomm to the new namespace #6025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Migrate backends/qualcomm to the new namespace #6025

wants to merge 1 commit into from

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Oct 8, 2024

Summary: Move the qualcomm backend out of the torch:: namespace, and update to avoid using the torch:: or exec_aten:: namespaces.

Differential Revision: D64073805

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6025

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 41bacd8 with merge base b6e6d06 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64073805

@dbort dbort requested a review from cccclai October 8, 2024 23:02
@cccclai cccclai requested review from shewu-quic and chiwwang October 8, 2024 23:05
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64073805

dbort added a commit to dbort/executorch that referenced this pull request Oct 8, 2024
@dbort @facebook-github-bot
Migrate backends/qualcomm to the new namespace (pytorch#6025)
e536567 
Summary:
Pull Request resolved: pytorch#6025

Move the qualcomm backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Differential Revision: D64073805
@dbort dbort force-pushed the export-D64073805 branch from 223fea2 to e536567 Compare October 8, 2024 23:33
shewu-quic
shewu-quic approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@shewu-quic shewu-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for helping with this.

cccclai
cccclai approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp on behalf of QCOMM team

@cccclai cccclai mentioned this pull request Oct 9, 2024
Closed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64073805

dbort added a commit to dbort/executorch that referenced this pull request Oct 9, 2024
@dbort @facebook-github-bot
Migrate backends/qualcomm to the new namespace (pytorch#6025)
4eb8254 
Summary:
Pull Request resolved: pytorch#6025

Move the qualcomm backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Reviewed By: cccclai

Differential Revision: D64073805
@dbort dbort force-pushed the export-D64073805 branch from e536567 to 4eb8254 Compare October 9, 2024 04:46
@dbort @facebook-github-bot
Migrate backends/qualcomm to the new namespace (pytorch#6025)
41bacd8 
Summary:
Pull Request resolved: pytorch#6025

Move the qualcomm backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Reviewed By: cccclai

Differential Revision: D64073805
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64073805

@dbort dbort force-pushed the export-D64073805 branch from 4eb8254 to 41bacd8 Compare October 9, 2024 04:53
chiwwang
chiwwang approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@chiwwang chiwwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel ok. @shewu-quic also feel ok then it's good to go from QC view!

@dbort
Copy link
Contributor Author

dbort commented Oct 9, 2024

@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b8f66f9.

@dbort dbort deleted the export-D64073805 branch October 9, 2024 18:22
@dbort
Copy link
Contributor Author

dbort commented Oct 9, 2024

@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Oct 9, 2024
@dbort @pytorchbot
Migrate backends/qualcomm to the new namespace (#6025)
749304d 
Summary:
Pull Request resolved: #6025

Move the qualcomm backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Reviewed By: cccclai

Differential Revision: D64073805

fbshipit-source-id: d0ab30f598a337367cebb1be3a1b6d94285da9f0
(cherry picked from commit b8f66f9)
@pytorchbot
Copy link
Collaborator

Cherry picking #6025

The cherry pick PR is at #6060 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai approved these changes

@chiwwang chiwwang chiwwang approved these changes

@shewu-quic shewu-quic shewu-quic approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dbort @facebook-github-bot @pytorchbot @cccclai @chiwwang @shewu-quic