Skip to content

Implement Graph node #6037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Abhi-hpp
Copy link
Contributor

@Abhi-hpp Abhi-hpp commented Oct 9, 2024

Summary: Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Differential Revision: D64080291

Copy link

pytorch-bot bot commented Oct 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6037

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 88960fc with merge base 27330f2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Oct 9, 2024
Summary:
Pull Request resolved: pytorch#6037

Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Differential Revision: D64080291
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Oct 9, 2024
Summary:
Pull Request resolved: pytorch#6037

Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Differential Revision: D64080291
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Oct 9, 2024
Summary:
Pull Request resolved: pytorch#6037

Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Differential Revision: D64080291
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Oct 9, 2024
Summary:
Pull Request resolved: pytorch#6037

Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Differential Revision: D64080291
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Oct 9, 2024
Summary:
Pull Request resolved: pytorch#6037

Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Differential Revision: D64080291
@Abhi-hpp Abhi-hpp force-pushed the export-D64080291 branch 2 times, most recently from a636a70 to c6d80e1 Compare October 9, 2024 17:43
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Oct 9, 2024
Summary:

Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Differential Revision: D64080291
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Oct 9, 2024
Summary:
Pull Request resolved: pytorch#6037

Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Differential Revision: D64080291
Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Oct 9, 2024
Summary:
Pull Request resolved: pytorch#6037

Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Differential Revision: D64080291
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Oct 9, 2024
Summary:
Pull Request resolved: pytorch#6037

Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Differential Revision: D64080291
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Oct 9, 2024
Summary:
Pull Request resolved: pytorch#6037

Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Reviewed By: SS-JIA

Differential Revision: D64080291
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Oct 9, 2024
Summary:
Pull Request resolved: pytorch#6037

Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Reviewed By: SS-JIA

Differential Revision: D64080291
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Oct 9, 2024
Summary:
Pull Request resolved: pytorch#6037

Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Reviewed By: SS-JIA

Differential Revision: D64080291
Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Oct 9, 2024
Summary:
Pull Request resolved: pytorch#6037

Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Reviewed By: SS-JIA

Differential Revision: D64080291
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

Summary:
Pull Request resolved: pytorch#6037

Introduce Graph node which will be the parent class for nodes. This allows us to have different nodes that correspond to different vk command buffer functions including shader dispatch.

Reviewed By: SS-JIA

Differential Revision: D64080291
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64080291

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in df5b2ab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants