Add sigmoid to one-to-one annotator in ArmQuantizer #6047
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of fixed qspec, sigmoid then becomes annotated with the q-spec from the Quantization fix, similar to other table implemented operators. This fixes the issues introduced by pytorch#5832 Signed-off-by: Erik Lundell <[email protected]> Change-Id: I7afccf2036e3bdabea71d3f90b79a04b7f522e1f
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6047
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5099523 with merge base a6b213b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Erik-Lundell
added
partner: arm
digantdesai
approved these changes
Oct 15, 2024
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai merged this pull request in fe1b2e7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of fixed qspec, sigmoid then becomes annotated with the q-spec from the Quantization fix, similar to other table implemented operators.
This fixes the issues introduced by
#5832
Change-Id: I7afccf2036e3bdabea71d3f90b79a04b7f522e1f