Skip to content

Use only cmake for MacOS CI to save capacity #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Use only cmake for MacOS CI to save capacity #613

wants to merge 3 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Oct 4, 2023 •
edited
Loading

This change updates the gather script to:

  1. Use only cmake for MacOS CI to save capacity. This cuts the number of MacOS job in half
  2. Fix the wrong and confusing reference of linux.2xlarge on MacOS jobs

@huydhn huydhn requested review from malfet and guangy10 October 4, 2023 17:46
@netlify
Copy link

netlify bot commented Oct 4, 2023 •
edited
Loading

✅ Deploy Preview for resplendent-gnome-14e531 canceled.

Name Link
🔨 Latest commit f29f3be
🔍 Latest deploy log https://app.netlify.com/sites/resplendent-gnome-14e531/deploys/651dbc7441eac5000842aaee

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2023
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@huydhn huydhn marked this pull request as ready for review October 4, 2023 17:54
@huydhn huydhn changed the title Use only buck2 for MacOS CI to save capacity Use only cmake for MacOS CI to save capacity Oct 4, 2023
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@huydhn merged this pull request in d935d9a.

@huydhn huydhn deleted the macos-buck2-only branch December 17, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@guangy10 guangy10 Awaiting requested review from guangy10

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huydhn @facebook-github-bot @malfet