Skip to content

Handle output from TOSA reference model being int8 #6190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

per
Copy link
Collaborator

@per per commented Oct 14, 2024

Move TOSA reference model pin. This adds bugfix for .npy array to now be aligned to output int8 for BI models.

Make sure the dequantization not overflows by adding a cast to int32.

Change-Id: I2274955bc02a6f3a75687bb2f731b2058834c44f

Move TOSA reference model. This add .npy array now is
aligned to output int8 for BI models.
Make sure the dequantization not overflows by adding a cast
to int32.

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I2274955bc02a6f3a75687bb2f731b2058834c44f
Copy link

pytorch-bot bot commented Oct 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6190

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4c0fd83 with merge base cd2d2b4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2024
@kirklandsign kirklandsign added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Oct 14, 2024
@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@digantdesai merged this pull request in c544d0a.

@per per deleted the tosa_ref_update branch November 15, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants