Properly introduce selective build options #625
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49935141 |
larryliu0820
force-pushed
the
export-D49935141
branch
from
77a8ce4 to
d6d62f3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49935141 |
larryliu0820
force-pushed
the
export-D49935141
branch
from
d6d62f3 to
c379d05
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49935141 |
Summary: Refactor options to do selective build. * `EXECUTORCH_SELECT_ALL_OPS` by default `ON`, will be set to `OFF` if any of the other options is on. * `EXECUTORCH_SELECT_OPS_LIST` by default `OFF` * `EXECUTORCH_SELECT_OPS_YAML` by default `OFF`. This allows these options to be used outside of selective build examples. Reviewed By: digantdesai Differential Revision: D49935141
larryliu0820
force-pushed
the
export-D49935141
branch
from
c379d05 to
9c985f1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49935141 |
|
This pull request has been merged in 974e2e3. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
* unified quantizer for 4b * typo * typo * fix argument spec * gguf interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactor options to do selective build.
EXECUTORCH_SELECT_ALL_OPSby defaultON, will be set toOFFif any of the other options is on.EXECUTORCH_SELECT_OPS_LISTby defaultOFFEXECUTORCH_SELECT_OPS_YAMLby defaultOFF.This allows these options to be used outside of selective build examples.
Differential Revision: D49935141