Skip to content

Refactor preprocess to use EagerModelBase #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Oct 28, 2024

Copy link

pytorch-bot bot commented Oct 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6530

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e70cb5d with merge base 85d3ff6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@lucylq lucylq mentioned this pull request Oct 28, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 28, 2024
@lucylq lucylq changed the title refactor preprocess to use EagerModelBase Refactor preprocess to use EagerModelBase and add CI test Oct 28, 2024
@lucylq lucylq changed the title Refactor preprocess to use EagerModelBase and add CI test Refactor preprocess to use EagerModelBase Oct 28, 2024
Comment on lines +35 to +48
# Export.
# ep = torch.export.export(
# model.get_eager_model(),
# model.get_example_inputs(),
# dynamic_shapes=model.get_dynamic_shapes(),
# strict=False,
# )
#
# # AOTInductor
# torch._inductor.aot_compile(
# ep.module(),
# model.get_example_inputs(),
# options={"aot_inductor.output_path": "preprocess_aoti.so"},
# )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why commented out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6553

Aoti still requires pytorch/pytorch#137063, Richard said will try to land eow.

@lucylq lucylq merged commit 8f8e49b into gh/lucylq/9/base Oct 29, 2024
46 checks passed
@lucylq lucylq deleted the gh/lucylq/9/head branch October 29, 2024 22:07
@lucylq lucylq restored the gh/lucylq/9/head branch October 29, 2024 22:27
kirklandsign added a commit that referenced this pull request Oct 29, 2024
refactor preprocess to use EagerModelBase

ghstack-source-id: d2ac7e1
Pull Request resolved: #6530

Co-authored-by: lucylq <[email protected]>
@lucylq lucylq deleted the gh/lucylq/9/head branch January 24, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants