Executorch ops fail to build on macbook M1 due to bad formatting #6578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
```
....
executorch/kernels/quantized/cpu/embeddingxb.cpp:140:11: error: format specifies type 'char' but the argument has type 'int32_t' (aka 'int') [-Werror,-Wformat]
i,
^~
executorch/runtime/platform/assert.h:39:59: note: expanded from macro 'ET_CHECK_MSG'
ET_ASSERT_MESSAGE_EMIT(" (%s): " _format, #_cond, ##__VA_ARGS__); \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
executorch/runtime/platform/assert.h:26:9: note: expanded from macro 'ET_ASSERT_MESSAGE_EMIT'
##__VA_ARGS__)
~~^~~~~~~~~~~~
executorch/runtime/platform/log.h:172:13: note: expanded from macro 'ET_LOG'
##__VA_ARGS__); \
^~~~~~~~~~~
1 warning and 1 error generated.
```
Reviewed By: dongpujin, manuelcandales
Differential Revision: D65156573
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6578
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4862ba5 with merge base f813b6a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65156573 |
veselinp
requested review from
manuelcandales and
metascroy
and removed request for
manuelcandales
manuelcandales
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reviewed By: dongpujin, manuelcandales
Differential Revision: D65156573