Remove typing true flag from executorch #6612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6612
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65343496 |
zingo
added
partner: arm
|
Please seek CI approval before scheduling CIFlow labels |
|
It would be nice if it is possible to make this run the ciflow/trunk tests to make sure Arm testing is executed and still work. It should probably not be any problem but still be nice. |
Summary: This is on our blocklist - it shouldn't be opted into PTT typing Reviewed By: grievejia Differential Revision: D65343496
MaggieMoss
force-pushed
the
export-D65343496
branch
from
f5aede3 to
bb6e79b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65343496 |
|
I have tested this a bit internally and it seem to cause no problem, I even removed all of "typing = True," under the arm folder without problem. |
zingo
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is on our blocklist - it shouldn't be opted into PTT typing
Reviewed By: grievejia
Differential Revision: D65343496