Add in-memory log buffer in Android JNI #6656
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add an in-memory log buffer implementation for Android JNI. This is an experimental feature intended to allow developers easier access to ET log strings at runtime.
The new API is availble on the JNI Module class:
Test plan
Added temporary test code to Android demo app (not committed):
Output:
Also, I added quick code to ET_LOG 10000 times to sanity check log buffer wrapping. Also, in the medium-term, it would be nice to invest in unit-level tests for the JNI layer.