Support sym round and ceil #6699
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6699
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7b969aa with merge base 8f82198 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65382714 |
GregoryComer
force-pushed
the
export-D65382714
branch
from
d53c9d6 to
aadcddb
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Add prim op implementations for sym round and ceil. Support round in pass_base interpreter. Test Plan: Added tests for ceil and round in prim_ops_test.cpp. `buck test executorch/kernels/prim_ops/test:` Differential Revision: D65382714 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D65382714
branch
from
aadcddb to
5a28052
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65382714 |
| if (a.isDouble()) { | ||
| out = EValue(static_cast<int64_t>(ceil(a.toDouble()))); | ||
| } else { | ||
| ET_CHECK_MSG(false, "%zu", (size_t)a.tag); |
There was a problem hiding this comment.
This feels a bit too succinct, please add some explanation why it's unimportant to have it for other dtypes
Summary: Add prim op implementations for sym round and ceil. Support round in pass_base interpreter. Test Plan: Added tests for ceil and round in prim_ops_test.cpp. Round is also test end to end with MSGR ODNC model. `buck test executorch/kernels/prim_ops/test:` Reviewed By: malfet Differential Revision: D65382714 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D65382714
branch
from
5a28052 to
562ab87
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65382714 |
Summary: Add prim op implementations for sym round and ceil. Support round in pass_base interpreter. Test Plan: Added tests for ceil and round in prim_ops_test.cpp. Round is also test end to end with MSGR ODNC model. `buck test executorch/kernels/prim_ops/test:` Reviewed By: malfet Differential Revision: D65382714 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D65382714
branch
from
562ab87 to
7b969aa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65382714 |
Summary: Add prim op implementations for sym round and ceil. Support round in pass_base interpreter.
Differential Revision: D65382714