Swap mha #6719
Merged
Swap mha #6719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6719
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b373248 with merge base 7fcd0af ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jackzhxng
force-pushed
the
jz/mha-swap
branch
2 times, most recently
from
03b44fc to
3f87c3b
Compare
jackzhxng
added
the
release notes: examples
larryliu0820
approved these changes
Nov 11, 2024
jackzhxng
force-pushed
the
jz/mha-swap
branch
from
ab205c8 to
b373248
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Swap TorchTune's attention to an ET copy that enables swapping SDPA modules, such as the more performant custom SDPA modules here.
ET version of attention.py is up-to-date as of
73aa1267cd35c84c19bb2eb53c1c551a68d4fff0(pytorch/torchtune#1763)Test plan
Added unit tests for eager, export, and et: