[Android] Added instrumentation test for Module #6751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6751
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6b1a7ab with merge base 289e84e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@davidlin54 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| androidTestImplementation 'com.google.gms:google-services:4.3.3' | ||
| } | ||
|
|
||
| task('setupNativeLibs', type: Exec){ |
There was a problem hiding this comment.
Is it possible that we depend on ET AAR for this test?
There was a problem hiding this comment.
Oh I saw it from line 50
kirklandsign
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Created a new project
android_testunder extensions. This allows instrumentation tests to be created forModule.javaandLlamaModule.javabecause they need the native libraries. I chose not to changeextension/androidsince that would change the Java module to an Android module, and create an.aarinstead of a.jar.Testing
TODO:
LlamaModule.javaextension/androidtoextension/android_testto centralize the testing logic