Tighten type hints for tensor arithmetic #6752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes pytorch/pytorch#124015 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov X-link: pytorch/pytorch#135392 Differential Revision: D65753120 Pulled By: ezyang
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6752
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d0a1ba1 with merge base 7fcd0af ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65753120 |
mergennachin
approved these changes
Nov 11, 2024
facebook-github-bot
pushed a commit
to pytorch/torchrec
that referenced
this pull request
Nov 11, 2024
Summary: Pull Request resolved: #2550 X-link: pytorch/executorch#6752 Fixes pytorch/pytorch#124015 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov X-link: pytorch/pytorch#135392 Reviewed By: bobrenjc93, malfet Differential Revision: D65753120 Pulled By: ezyang fbshipit-source-id: 28ae18661b71078fa1dfdf8c60d1a75bec2f3e39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes pytorch/pytorch#124015
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov
X-link: pytorch/pytorch#135392
Differential Revision: D65753120
Pulled By: ezyang