Skip to content

move junit tests to android_test #6761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2024
Merged

move junit tests to android_test #6761

merged 3 commits into from
Nov 11, 2024

Conversation

davidlin54
Copy link
Contributor

@davidlin54 davidlin54 commented Nov 11, 2024 •
edited
Loading

Move JUnit tests to android_test to centralize both unit tests and instrumentation tests.

@davidlin54
Update
e36ca0a 
[ghstack-poisoned]
@davidlin54
Update
48fcae1 
[ghstack-poisoned]
@davidlin54
Update
ceac4b1 
[ghstack-poisoned]
@davidlin54
Copy link
Contributor Author

davidlin54 commented Nov 11, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@davidlin54 davidlin54 mentioned this pull request Nov 11, 2024
Merged
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6761

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ceac4b1 with merge base b23c9e6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@davidlin54 davidlin54 mentioned this pull request Nov 11, 2024
Merged
davidlin54 added a commit that referenced this pull request Nov 11, 2024
@davidlin54
move junit tests to android_test
0ccc9a8 
ghstack-source-id: e7f6e83
ghstack-comment-id: 2468974339
Pull Request resolved: #6761
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 11, 2024
Base automatically changed from gh/davidlin54/4/head to main November 11, 2024 21:00
@davidlin54 davidlin54 merged commit b8b5146 into main Nov 11, 2024
38 checks passed
@davidlin54 davidlin54 deleted the gh/davidlin54/5/head branch November 11, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirklandsign kirklandsign kirklandsign approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidlin54 @kirklandsign @facebook-github-bot