Skip to content

Add PR release note label checker bot #6835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 19, 2024
Merged

Add PR release note label checker bot #6835

merged 6 commits into from
Nov 19, 2024

Conversation

jackzhxng
Copy link
Contributor

Summary

Add gh actions workflow for checking that there is a Release notes: or topic: not user facing label is added to each PR.

Test plan

Testing with this PR

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6835

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 72ab2f9 with merge base 3784f06 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 13, 2024
guangy10
guangy10 reviewed Nov 13, 2024
View reviewed changes
guangy10
guangy10 reviewed Nov 13, 2024
View reviewed changes
.github/workflows/check-labels.yml
Comment on lines +13 to +17
# To check labels on ghstack PRs.
# Note: as pull_request doesn't trigger on PRs targeting main,
# to test changes to the workflow itself one needs to create
# a PR that targets a gh/**/base branch.
pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create this PR from codev by exporting it using ghstack so you can test on a gh/ branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6930 for ghstack

@guangy10 guangy10 requested a review from huydhn November 13, 2024 22:33
@jackzhxng
Add release note label checker bot
99df003 
ghstack-source-id: cb91383
ghstack-comment-id: 2483597745
Pull Request resolved: #6927
@jackzhxng
Fix formatting (?)
4cdcc84 
ghstack-source-id: 58a1e6e
ghstack-comment-id: 2483597853
Pull Request resolved: #6928
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@jackzhxng jackzhxng requested a review from guangy10 November 18, 2024 22:09
huydhn
huydhn reviewed Nov 18, 2024
View reviewed changes
.github/workflows/check-labels.yml
if: github.repository_owner == 'pytorch'
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me double check the behavior of actions/checkout a bit to make sure that this is secure

huydhn
huydhn reviewed Nov 18, 2024
View reviewed changes
@jackzhxng jackzhxng merged commit 8cce45b into main Nov 19, 2024
39 checks passed
@jackzhxng jackzhxng deleted the jz/label-bot branch November 19, 2024 00:23
@kirklandsign
Copy link
Contributor

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

Does it work?

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 19, 2024

Didn't find following labels among repository labels: topic: not user facing

@jackzhxng
Copy link
Contributor Author

@kirklandsign were some issues with the comment deletion - please see #6953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

@guangy10 guangy10 Awaiting requested review from guangy10

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackzhxng @kirklandsign @huydhn @guangy10 @facebook-github-bot