Skip to content

Fix custom annotation #6978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix custom annotation #6978

merged 1 commit into from
Nov 20, 2024

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Nov 20, 2024

Summary: Looks like it's added in #6849, maybe it was using the old api for the default 8bit quantization

Differential Revision: D66219251

Summary: Looks like it's added in  pytorch#6849, maybe it was using the old api for the default 8bit quantization

Differential Revision: D66219251
Copy link

pytorch-bot bot commented Nov 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6978

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit e5315fe with merge base dcacde0 (image):

NEW FAILURE - The following job has failed:

  • pull / unittest-arm / linux-job (gh)
    ##[error]fatal: unable to access 'https://git.mlplatform.org/ml/ethos-u/ethos-u-core-driver.git/': Failed to connect to git.mlplatform.org port 443 after 34 ms: Couldn't connect to server

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66219251

@shewu-quic
Copy link
Collaborator

Thanks for your fix. I am also preparing the PR to fix it.

Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was just looking into unbreaking lintrunner, thanks!

@cccclai cccclai merged commit 359e9d3 into pytorch:main Nov 20, 2024
40 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants