-
Notifications
You must be signed in to change notification settings - Fork 604
[Executorch][CI] Fix qnn runner ci job scripts #7049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
QNN backend's AOT artifacts were being copied in the source directory instead of them being installed, as build artifacts, in appropriate package directory. As a result we had to use PYTHON_PATH=".." in test_llama.sh CI script when running CI for qnn. This results in executorch having two locations as where the package is installed. This PR fixes that. Differential Revision: [D66406274](https://our.internmc.facebook.com/intern/diff/D66406274/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7049
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Merge Blocking SEVsThere is 1 active merge blocking SEVs. Please view them below:
If you must merge, use ❌ 10 New Failures, 1 Cancelled JobAs of commit 51523e8 with merge base 43555d2 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D66406274 |
QNN backend's AOT artifacts were being copied in the source directory instead of them being installed, as build artifacts, in appropriate package directory. As a result we had to use PYTHON_PATH=".." in test_llama.sh CI script when running CI for qnn. This results in executorch having two locations as where the package is installed. This PR fixes that. Differential Revision: [D66406274](https://our.internmc.facebook.com/intern/diff/D66406274/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D66406274 |
QNN backend's AOT artifacts were being copied in the source directory instead of them being installed, as build artifacts, in appropriate package directory. As a result we had to use PYTHON_PATH=".." in test_llama.sh CI script when running CI for qnn. This results in executorch having two locations as where the package is installed. This PR fixes that. Differential Revision: [D66406274](https://our.internmc.facebook.com/intern/diff/D66406274/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D66406274 |
I am gonna have to abandon this because imports of model in qnn backend think that examples are part of the pip package of executorch. And to get around that we need to do PYTHON_PATH="EXECUTORCH_ROOT". I really dont like it, but dont have bandwidth to figure out better solution. So I will work around it for the purpose of this stack. cc: @cccclai @larryliu0820 |
@kimishpatel hmm how does this stack affect qnn CI job? |
Not directly, but now we are importing quantized_kv_cache unconditionally from export_llama_lib. Because qnn CI stack has 1) PYTHON_PATH=.. which affects python imports and confuses the location of where executorch package is installed and 2) various models in examples/backends/qualcomm treat examples folder (as in 2 in particularly is problematic because I see that pattern in a few places but it is not clear if examples is supposed be part of pip package. @larryliu0820 should confirm |
Ideally we shouldn’t include examples in pip package. Anything reusable should go into extension.Ilm and should not tied to any specific model. For example I’m aware a lot of code useful for llama are still in examples.models.llama. They should really go inside extension.llm for reusability |
There much more widepsread use of pattern |
Seems stale |
Pull Request resolved: pytorch/executorch#7049 QNN backend's AOT artifacts were being copied in the source directory instead of them being installed, as build artifacts, in appropriate package directory. As a result we had to use PYTHON_PATH=".." in test_llama.sh CI script when running CI for qnn. This results in executorch having two locations as where the package is installed. This PR fixes that. ghstack-source-id: 255154890 @exported-using-ghexport Differential Revision: [D66406274](https://our.internmc.facebook.com/intern/diff/D66406274/)
Stack from ghstack (oldest at bottom):
QNN backend's AOT artifacts were being copied in the source directory instead of
them being installed, as build artifacts, in appropriate package directory.
As a result we had to use PYTHON_PATH=".." in test_llama.sh CI script when
running CI for qnn. This results in executorch having two locations as where
the package is installed. This PR fixes that.
Differential Revision: D66406274