Skip to content

Support to init BundledProgram from pte file #7278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

YIWENX14
Copy link
Contributor

Summary: Added an optional pte_file_path arg to BundledProgram's init function. This is to allow users to create bundled program with varied inputs after exporting.

Differential Revision: D67013542

Copy link

pytorch-bot bot commented Dec 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7278

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 892a2ee with merge base 343aa0c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 10, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67013542

Summary:

Added an optional `pte_file_path` arg to BundledProgram's init function. This is to allow users to create bundled program with varied inputs after exporting.

Reviewed By: tarun292

Differential Revision: D67013542
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67013542

@facebook-github-bot facebook-github-bot merged commit 8fc3f8c into pytorch:main Dec 11, 2024
5 of 7 checks passed
Copy link
Collaborator

@zingo zingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem to cause major problem

from pyre_extensions import none_throws

As pyre is not installed in the github project. I kicked of a revert to test if and added the trunk flag to get more testing on it.

@digantdesai
Copy link
Contributor

digantdesai commented Dec 11, 2024

@zingo - Wonder why the CI here is clean.
Edit: I do see some issues with the CI.

@zingo
Copy link
Collaborator

zingo commented Dec 11, 2024

This revert is maybe not be the thing you want to do, I just used it to highlight the problems, and test if it solves it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants