Separate buck targets per operator. #7314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7314
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5d12f5c with merge base 61b9e1b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67128598 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Dec 12, 2024
Summary: Keep targets separate so we only compile the operators we need. Reviewed By: zonglinpeng Differential Revision: D67128598
hsharma35
force-pushed
the
export-D67128598
branch
from
3ebdbee to
0219f5f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67128598 |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Dec 12, 2024
Summary: Keep targets separate so we only compile the operators we need. Reviewed By: zonglinpeng Differential Revision: D67128598
hsharma35
force-pushed
the
export-D67128598
branch
from
0219f5f to
175cc4c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67128598 |
zonglinpeng
approved these changes
Dec 12, 2024
Summary: Create a separate buck target for `TestUtil.h` that can be used by backends. The current `test_util` target has dependencies that don't compile for xtensa toolchain. Reviewed By: zonglinpeng Differential Revision: D67128600
Summary: Overrides for `et_pal*` weak symbols for logging/timing with xtensa ISS. Reviewed By: zonglinpeng Differential Revision: D67128599
…rch#7312) Summary: Use ET_KERNEL_CHECK to detect error codes returned by xa_nn* library calls. Reviewed By: zonglinpeng Differential Revision: D67128597
Summary: Keep targets separate so we only compile the operators we need. Reviewed By: zonglinpeng Differential Revision: D67128598
hsharma35
force-pushed
the
export-D67128598
branch
from
175cc4c to
5d12f5c
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Dec 12, 2024
Summary: Keep targets separate so we only compile the operators we need. Reviewed By: zonglinpeng Differential Revision: D67128598
|
This pull request was exported from Phabricator. Differential Revision: D67128598 |
hsharma35
added a commit
that referenced
this pull request
Dec 12, 2024
* Allow backends/cadence to use TestUtil.h. (#7304) Summary: Create a separate buck target for `TestUtil.h` that can be used by backends. The current `test_util` target has dependencies that don't compile for xtensa toolchain. Reviewed By: zonglinpeng Differential Revision: D67128600 * Xtensa ISS PAL layer for logging/timing. (#7311) Summary: Overrides for `et_pal*` weak symbols for logging/timing with xtensa ISS. Reviewed By: zonglinpeng Differential Revision: D67128599 * Use macro `XT_KERNEL_CHECK` to handle errors returned by nnlib. (#7312) Summary: Use ET_KERNEL_CHECK to detect error codes returned by xa_nn* library calls. Reviewed By: zonglinpeng Differential Revision: D67128597 * Separate buck targets per operator. (#7314) Summary: Keep targets separate so we only compile the operators we need. Reviewed By: zonglinpeng Differential Revision: D67128598 * FusionG3 operators. (#7315) Summary: Cleanup header order and `using` declarations for operators to match style guide. Reviewed By: zonglinpeng Differential Revision: D67128499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Keep targets separate so we only compile the operators we need.
Reviewed By: zonglinpeng
Differential Revision: D67128598