Skip to content

Revert "Add full operator to fold dq/q handling" #7351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 18, 2024
Merged

Revert "Add full operator to fold dq/q handling" #7351

merged 10 commits into from
Dec 18, 2024

Conversation

digantdesai
Copy link
Contributor

@digantdesai digantdesai commented Dec 18, 2024

This reverts recent commits from Arm because it is causing internal type checking errors.

@per - sorry about this. Let me work with you to remerge these ASAP.

This reverts commit 47c2f2e.

Signed-off-by: Digant Desai <[email protected]>
This reverts commit eae61f7.

Signed-off-by: Digant Desai <[email protected]>
This reverts commit fd9eb28.

Signed-off-by: Digant Desai <[email protected]>
This reverts commit 2d39f78.

Signed-off-by: Digant Desai <[email protected]>
This reverts commit bcbc4c6.

Signed-off-by: Digant Desai <[email protected]>
This reverts commit 70f95d0.

Signed-off-by: Digant Desai <[email protected]>
@digantdesai digantdesai requested a review from per December 18, 2024 03:57
Copy link

pytorch-bot bot commented Dec 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7351

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 03aafbe with merge base 72bb7b7 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 18, 2024
@digantdesai digantdesai requested a review from iseeyuan December 18, 2024 03:57
Copy link
Contributor

@iseeyuan iseeyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @digantdesai for unblocking the internal diff train!

@digantdesai digantdesai merged commit 11beed1 into main Dec 18, 2024
43 of 46 checks passed
@digantdesai digantdesai deleted the arm_revert branch December 18, 2024 04:54
@per
Copy link
Collaborator

per commented Dec 18, 2024

@digantdesai - would be helpful to get logs or indication on where the pyre errors are. Running pyre with some default strict configuration gives the same results with or without the reverted commits. So completely in the dark here on how to approach this.

per added a commit to per/executorch that referenced this pull request Dec 18, 2024
per added a commit to per/executorch that referenced this pull request Dec 19, 2024
This reverts commit 11beed1.

Change-Id: I6ba9b37f069c3ad819114fe1384659bc0f68135f
per added a commit to per/executorch that referenced this pull request Dec 19, 2024
This reverts commit 11beed1.

Change-Id: I6ba9b37f069c3ad819114fe1384659bc0f68135f
digantdesai pushed a commit that referenced this pull request Dec 20, 2024
)

* Revert "[Arm] Fix merge conflicts after previous reverts (#7353)"

This reverts commit 44e31fb.

Change-Id: I12d88419e45a800e43e1e31d21280bc3b63710c6

* Revert "Revert "Add full operator to fold dq/q handling" (#7351)"

This reverts commit 11beed1.

Change-Id: I6ba9b37f069c3ad819114fe1384659bc0f68135f

* Fix type checker issues

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: Iee35eeb4af28a037848570b1d5143380222f549d

* Address pyre checks from Meta internal tools

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I60fb32ad55a3f6d3617993481ab0c1ed46cf778c

* Fix more typecheckings

Change-Id: I37fb7468b5cb040b916fabb2784ec475318bddba

* Reapply pyre-ignores after lintrunner moves

lintrunner moved the pyre-ignores to the wrong line, re-apply to the
right line again.

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: Icbb6cf6f2d65d6fe1c00e7c4a738691ffeb7acb2

---------

Signed-off-by: Per Åstrand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants