Support ceil_mode=True on maxpool2d in XNNPACK delegate #7355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7355
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f0474f4 with merge base 6c3a792 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67386151 |
GregoryComer
added
the
release notes: backends [DO NOT USE]
GregoryComer
force-pushed
the
export-D67386151
branch
from
a27bbd1 to
0711133
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 19, 2024
Summary: Support ceil_mode=True for MaxPool2d in XNNPACK delegate by conditionally updating padding. This works only when the input shape is static, as it requires statically computing the change in padding. As such, the partitioner constraints are also updated to reflect this. Test Plan: Added a new test (test_fp32_maxpool2d_ceilmode) that exercises various permutations of input with ceil_mode=True. Reviewed By: digantdesai, mcr229 Differential Revision: D67386151 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67386151
branch
from
0711133 to
e773e3a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67386151 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 20, 2024
Summary: Support ceil_mode=True for MaxPool2d in XNNPACK delegate by conditionally updating padding. This works only when the input shape is static, as it requires statically computing the change in padding. As such, the partitioner constraints are also updated to reflect this. Test Plan: Added a new test (test_fp32_maxpool2d_ceilmode) that exercises various permutations of input with ceil_mode=True. Reviewed By: digantdesai, mcr229 Differential Revision: D67386151 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67386151
branch
from
e773e3a to
212ef58
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67386151 |
Summary: Support ceil_mode=True for MaxPool2d in XNNPACK delegate by conditionally updating padding. This works only when the input shape is static, as it requires statically computing the change in padding. As such, the partitioner constraints are also updated to reflect this. Test Plan: Added a new test (test_fp32_maxpool2d_ceilmode) that exercises various permutations of input with ceil_mode=True. Reviewed By: digantdesai, mcr229 Differential Revision: D67386151 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67386151
branch
from
212ef58 to
f0474f4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67386151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Support ceil_mode=True for MaxPool2d in XNNPACK delegate by conditionally updating padding. This works only when the input shape is static, as it requires statically computing the change in padding. As such, the partitioner constraints are also updated to reflect this.
Differential Revision: D67386151