[ET-VK] Adding a common utility function to calculate 3d output position based on unique index. #7522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion based on unique index. This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7522
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 276c8ad with merge base 39e8538 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
trivedivivek
added a commit
that referenced
this pull request
Jan 6, 2025
…ion based on unique index. This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/) ghstack-source-id: 260372218 Pull Request resolved: #7522
|
This pull request was exported from Phabricator. Differential Revision: D67821941 |
…utput position based on unique index." This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Jan 6, 2025
…ion based on unique index. Pull Request resolved: #7522 This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. ghstack-source-id: 260376107 @exported-using-ghexport Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/)
|
This pull request was exported from Phabricator. Differential Revision: D67821941 |
jorgep31415
approved these changes
Jan 6, 2025
…utput position based on unique index." This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67821941 |
…utput position based on unique index." This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67821941 |
…utput position based on unique index." This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67821941 |
…utput position based on unique index." This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67821941 |
…utput position based on unique index." This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67821941 |
facebook-github-bot
merged commit bc14bd6
into
gh/trivedivivek/37/base
45 of 46 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trivedivivek
added a commit
that referenced
this pull request
Jan 9, 2025
…ion based on unique index. (#7564) Pull Request resolved: #7522 This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. ghstack-source-id: 260707858 @exported-using-ghexport Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/) Co-authored-by: Vivek Trivedi <[email protected]>
trivedivivek
added a commit
that referenced
this pull request
Jan 9, 2025
…ing input texel for reuse. (#7565) * [ET-VK] Adding a common utility function to calculate 3d output position based on unique index. Pull Request resolved: #7522 This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. ghstack-source-id: 260707858 @exported-using-ghexport Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/) * [ET-VK] Adding batch processing in x axis to conv2d dw shader by caching input texel for reuse. Pull Request resolved: #7526 This diff adds batch processing in the x axis to the conv2d dw shader by reusing input texel overlapping between consecutive tiles. The changes include modifying the glsl code for the conv2d dw output tile, adding a new parameter to the yaml file, and modifying the Convolution.cpp file to use the new parameter. ghstack-source-id: 260707856 Differential Revision: [D67868671](https://our.internmc.facebook.com/intern/diff/D67868671/) --------- Co-authored-by: Vivek Trivedi <[email protected]>
trivedivivek
added a commit
that referenced
this pull request
Jan 9, 2025
…htly improves perf. (#7566) * [ET-VK] Adding a common utility function to calculate 3d output position based on unique index. Pull Request resolved: #7522 This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. ghstack-source-id: 260707858 @exported-using-ghexport Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/) * [ET-VK] Adding batch processing in x axis to conv2d dw shader by caching input texel for reuse. Pull Request resolved: #7526 This diff adds batch processing in the x axis to the conv2d dw shader by reusing input texel overlapping between consecutive tiles. The changes include modifying the glsl code for the conv2d dw output tile, adding a new parameter to the yaml file, and modifying the Convolution.cpp file to use the new parameter. ghstack-source-id: 260707856 Differential Revision: [D67868671](https://our.internmc.facebook.com/intern/diff/D67868671/) * [ET-VK] Changing all conv 2d pw ints from uint16 to int since it slightly improves perf. Pull Request resolved: #7545 This diff changes all integers in conv 2d pw op shader from uint16 to int in the Vulkan backend of Executorch. The change is made to improve performance since the shader does not appear to be register bound. ghstack-source-id: 260707857 Differential Revision: [D67906023](https://our.internmc.facebook.com/intern/diff/D67906023/) --------- Co-authored-by: Vivek Trivedi <[email protected]>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
…ing input texel for reuse. (#7565) * [ET-VK] Adding a common utility function to calculate 3d output position based on unique index. Pull Request resolved: #7522 This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. ghstack-source-id: 260707858 @exported-using-ghexport Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/) * [ET-VK] Adding batch processing in x axis to conv2d dw shader by caching input texel for reuse. Pull Request resolved: #7526 This diff adds batch processing in the x axis to the conv2d dw shader by reusing input texel overlapping between consecutive tiles. The changes include modifying the glsl code for the conv2d dw output tile, adding a new parameter to the yaml file, and modifying the Convolution.cpp file to use the new parameter. ghstack-source-id: 260707856 Differential Revision: [D67868671](https://our.internmc.facebook.com/intern/diff/D67868671/) --------- Co-authored-by: Vivek Trivedi <[email protected]>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
…htly improves perf. (#7566) * [ET-VK] Adding a common utility function to calculate 3d output position based on unique index. Pull Request resolved: #7522 This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. ghstack-source-id: 260707858 @exported-using-ghexport Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/) * [ET-VK] Adding batch processing in x axis to conv2d dw shader by caching input texel for reuse. Pull Request resolved: #7526 This diff adds batch processing in the x axis to the conv2d dw shader by reusing input texel overlapping between consecutive tiles. The changes include modifying the glsl code for the conv2d dw output tile, adding a new parameter to the yaml file, and modifying the Convolution.cpp file to use the new parameter. ghstack-source-id: 260707856 Differential Revision: [D67868671](https://our.internmc.facebook.com/intern/diff/D67868671/) * [ET-VK] Changing all conv 2d pw ints from uint16 to int since it slightly improves perf. Pull Request resolved: #7545 This diff changes all integers in conv 2d pw op shader from uint16 to int in the Vulkan backend of Executorch. The change is made to improve performance since the shader does not appear to be register bound. ghstack-source-id: 260707857 Differential Revision: [D67906023](https://our.internmc.facebook.com/intern/diff/D67906023/) --------- Co-authored-by: Vivek Trivedi <[email protected]>
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
…ion based on unique index. Pull Request resolved: pytorch/executorch#7522 This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes. ghstack-source-id: 260707858 @exported-using-ghexport Differential Revision: [D67821941](https://our.internmc.facebook.com/intern/diff/D67821941/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff adds an indexing utils header file used in Vulkan backend of Executorch. The header file includes functions for converting a global index to u16 indices based on input sizes.
Differential Revision: D67821941