Work around flatccrt issue in CI script #7570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running build-qnn-sdk.sh in certain circumstances the libflatccrt.a cannot be found. To work around this we can build the QNN backend twice, second time with option `--no_clean`, to make sure the library is found. Resolves: pytorch#7300 Change-Id: I47e14f1fa318538587b848ee02240f7867c88f50 Signed-off-by: Benjamin Klimczak <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7570
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cdfbad3 with merge base b16271c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
Hi @dbort and @Olivia-liu. Could one of you have a look please to unblock #5027? |
Olivia-liu
approved these changes
Jan 13, 2025
|
@Olivia-liu can we dig into this issue and figure out the root cause? |
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
When running build-qnn-sdk.sh in certain circumstances the libflatccrt.a cannot be found. To work around this we can build the QNN backend twice, second time with option `--no_clean`, to make sure the library is found. Resolves: #7300 Change-Id: I47e14f1fa318538587b848ee02240f7867c88f50 Signed-off-by: Benjamin Klimczak <[email protected]>
Merged
jathu
added a commit
that referenced
this pull request
May 16, 2025
### Summary Seems like there is a race in building `libflatccrt.a`. This issue has existed for a while: #7300. It was temporarily mitigated in #7570 by just reducing the parallelism. In this diff I attempt to fix it. This is just my assumption of what is wrong. Given flatccrt builds a debug version with a `_d` suffix, if the target isn't depended on (i.e. some target don't use the conditional target name) then the order of how the lib is built causes a race. So for now, always use the non-debug version. Given it's a race, I was never able to repro the issue locally — I can't guarantee this is the problem. However, it seems my recent changes in #10855 has increased the frequency of the problem in CI. ### Test plan CI cc @larryliu0820
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
May 19, 2025
### Summary Seems like there is a race in building `libflatccrt.a`. This issue has existed for a while: pytorch#7300. It was temporarily mitigated in pytorch#7570 by just reducing the parallelism. In this diff I attempt to fix it. This is just my assumption of what is wrong. Given flatccrt builds a debug version with a `_d` suffix, if the target isn't depended on (i.e. some target don't use the conditional target name) then the order of how the lib is built causes a race. So for now, always use the non-debug version. Given it's a race, I was never able to repro the issue locally — I can't guarantee this is the problem. However, it seems my recent changes in pytorch#10855 has increased the frequency of the problem in CI. ### Test plan CI cc @larryliu0820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running build-qnn-sdk.sh in certain circumstances the libflatccrt.a cannot be found. To work around this we can build the QNN backend twice, second time with option
--no_clean, to make sure the library is found.Fixes #7300