Skip to content

stop double-installing ExecuTorch in one-off linux jobs #7578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

stop double-installing ExecuTorch in one-off linux jobs #7578

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1a77767
stop double-installing ExecuTorch in one-off linux jobs
swolchok Jan 9, 2025
9f523e5
Update on "stop double-installing ExecuTorch in one-off linux jobs"
Jan 10, 2025
db84935
Update on "stop double-installing ExecuTorch in one-off linux jobs"
Jan 10, 2025
981173c
Update on "stop double-installing ExecuTorch in one-off linux jobs"
Jan 10, 2025
7ffed3b
Update on "stop double-installing ExecuTorch in one-off linux jobs"
Jan 10, 2025
a854f7f
Update on "stop double-installing ExecuTorch in one-off linux jobs"
Jan 11, 2025
eb186b6
Update on "stop double-installing ExecuTorch in one-off linux jobs"
Jan 13, 2025
483f67a
Update on "stop double-installing ExecuTorch in one-off linux jobs"
swolchok Jan 15, 2025
d09a372
Update on "stop double-installing ExecuTorch in one-off linux jobs"
swolchok Jan 15, 2025
e1862fc
Update on "stop double-installing ExecuTorch in one-off linux jobs"
swolchok Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .github/workflows/pull.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,6 @@ jobs:

PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh "cmake"

# install pybind
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should stop double-installing, but I'd much rather remove the bespoke CI-only installation stuff in favor of install_requirements. I think that if we remove these calls to install_requirements, then none (or very few) of the CI jobs will actually exercise install_requirements. And removing the CI-only logic would reduce overall maintenance costs.

bash install_requirements.sh --pybind xnnpack

# install Llava requirements
bash examples/models/llama/install_requirements.sh
bash examples/models/llava/install_requirements.sh
Expand Down Expand Up @@ -435,9 +432,6 @@ jobs:

PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh "cmake"

# install pybind
bash install_requirements.sh --pybind xnnpack

# install phi-3-mini requirements
bash examples/models/phi-3-mini/install_requirements.sh

Expand All @@ -462,9 +456,6 @@ jobs:

PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh "cmake"

# install pybind
bash install_requirements.sh --pybind xnnpack

# install llama requirements
bash examples/models/llama/install_requirements.sh

Expand All @@ -489,10 +480,6 @@ jobs:

PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh "cmake"

# install pybind
bash install_requirements.sh --pybind xnnpack

# install llama requirements
bash examples/models/llama/install_requirements.sh

# run eval_llama mmlu task
Expand All @@ -516,9 +503,6 @@ jobs:

PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh "cmake"

# install pybind
bash install_requirements.sh --pybind xnnpack

# install llama requirements
bash examples/models/llama/install_requirements.sh

Expand Down
Loading