Fix duplication of classes in modules #7606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: If both the executorch and executorch_llama modules are included, this could cause class duplication errors. This fixes it by reorganizing the modules. Differential Revision: D68027619
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7606
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9bb6837 with merge base 9666ee8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68027619 |
|
@pytorchbot label "topic: not user facing" |
|
@kirklandsign can you take a look at this? |
Gasoonjia
approved these changes
Jan 15, 2025
|
Thank you! |
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Differential Revision: D68027619 Pull Request resolved: #7606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: If both the executorch and executorch_llama modules are included, this could cause class duplication errors. This fixes it by reorganizing the modules.
Differential Revision: D68027619