Skip to content

Fix uninitialized variable type-check in FuseQuantizedActivationPass #7671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

Tessil
Copy link
Collaborator

@Tessil Tessil commented Jan 15, 2025

This PR fixes the Uninitialized local type-checking error in FuseQuantizedActivationPass:

executorch/backends/arm/_passes/fuse_quantized_activation_pass.py:27:48 Uninitialized local [61]: Local variable `zp` is undefined, or not always defined.
executorch/backends/arm/_passes/fuse_quantized_activation_pass.py:27:54 Uninitialized local [61]: Local variable `qmin` is undefined, or not always defined.

@Tessil Tessil added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jan 15, 2025
Copy link

pytorch-bot bot commented Jan 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7671

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0bb3384 with merge base 0dba025 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2025
@Tessil Tessil force-pushed the toupstream/fused_activation_type_fix branch from ecb76ca to 0bb3384 Compare January 16, 2025 10:12
@freddan80 freddan80 merged commit cb45fb6 into pytorch:main Jan 17, 2025
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants