Skip to content

Arm backend: Remove the reordering of inputs flag #7698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2025
Merged

Arm backend: Remove the reordering of inputs flag #7698

merged 2 commits into from
Jan 16, 2025

Conversation

SaoirseARM
Copy link
Collaborator

@SaoirseARM SaoirseARM commented Jan 16, 2025 •
edited
Loading

Summary

  • With updated Vela version input/output order is now preserved.
  • Remove re-order of inputs in compile spec
  • Remove re-order of inputs in aot_arm_compiler

@SaoirseARM
Remove the reordering of inputs flag
ca1b136 
- With updated Vela version input/output order is now preserved.
- Remove re-order of inputs in compile spec
- Remove re-order of inputs in aot_arm_compiler
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7698

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Cancelled Jobs

As of commit 7c6982d with merge base d1b33cb (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jan 16, 2025
@oscarandersson8218
Copy link
Collaborator

@SaoirseARM Can you rebase this please?

@zingo zingo changed the title Remove the reordering of inputs flag Arm backend: Remove the reordering of inputs flag Jan 16, 2025
@zingo
Copy link
Collaborator

zingo commented Jan 16, 2025

MacOS tests are unrelated

@zingo zingo merged commit 6d78026 into pytorch:main Jan 16, 2025
105 of 107 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@SaoirseARM @YIWENX14
Arm backend: Remove the reordering of inputs flag (#7698)
17acc3b 
Remove the reordering of inputs flag

- With updated Vela version input/output order is now preserved.
- Remove re-order of inputs in compile spec
- Remove re-order of inputs in aot_arm_compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingo zingo zingo approved these changes

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SaoirseARM @oscarandersson8218 @zingo @facebook-github-bot