Skip to content

[Arm] Cleanup unused functions #7725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

per
Copy link
Collaborator

@per per commented Jan 17, 2025

Remove functions not used for searching/finding quantization information.

cc @digantdesai @freddan80 @zingo @oscarandersson8218

@per per added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Jan 17, 2025
Copy link

pytorch-bot bot commented Jan 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7725

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 0d3ef2b with merge base fedb035 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2025
@digantdesai
Copy link
Contributor

@per do you want to push again to re-run the CI?

per added 2 commits January 20, 2025 10:31
Remove functions not used for searching/finding quantization information.

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I5917e8b447dc21be78e79b2b0477c321fa09e262
The quantize io flag was removed in a prio commit.

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: Id10d6502fe4b39d453fc04d758666575e833ce19
@per per force-pushed the cleanup_unused_functions branch from f40305e to 0d3ef2b Compare January 20, 2025 09:31
@zingo
Copy link
Collaborator

zingo commented Jan 20, 2025

macos and phi test error seems unrelated to this PR (and fails in other PR)

@zingo zingo merged commit 04547f8 into pytorch:main Jan 20, 2025
106 of 108 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
Remove functions not used for searching/finding quantization information.

Signed-off-by: Per Åstrand <[email protected]>
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
Remove functions not used for searching/finding quantization information.

Signed-off-by: Per Åstrand <[email protected]>
@per per deleted the cleanup_unused_functions branch May 15, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants