Skip to content

[ET-VK][ez] Fix conv2d_pw shared memory buffer not having a constant size #7734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #7729
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/169/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/169/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/169/orig
@diff-train-skip-merge

…t size

## Context

`conv2d_pw` was failing to compile on Mac due to the shared memory array not having a constant size.

Simply hardcode the workgroup size to fix.

Differential Revision: [D68331984](https://our.internmc.facebook.com/intern/diff/D68331984/)

ghstack-source-id: 261911463
Pull Request resolved: #7729
Copy link

pytorch-bot bot commented Jan 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7734

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 23 Pending

As of commit 1b2c88c with merge base 1a6b7a6 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2025
@SS-JIA SS-JIA merged commit 8494b90 into main Jan 17, 2025
44 of 46 checks passed
@SS-JIA SS-JIA deleted the gh/SS-JIA/169/orig branch January 17, 2025 19:49
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
…t size (#7734)

## Context

`conv2d_pw` was failing to compile on Mac due to the shared memory array not having a constant size.

Simply hardcode the workgroup size to fix.

Differential Revision: [D68331984](https://our.internmc.facebook.com/intern/diff/D68331984/)

ghstack-source-id: 261911463
Pull Request resolved: #7729

Co-authored-by: Stephen Jia <[email protected]>
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
…t size (pytorch#7734)

## Context

`conv2d_pw` was failing to compile on Mac due to the shared memory array not having a constant size.

Simply hardcode the workgroup size to fix.

Differential Revision: [D68331984](https://our.internmc.facebook.com/intern/diff/D68331984/)

ghstack-source-id: 261911463
Pull Request resolved: pytorch#7729

Co-authored-by: Stephen Jia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants