Lintrunner: Enable mypy testing on backends/arm #7776

perheld · 2025-01-20T12:10:28Z

Migration from pyre to mypy in the lintrunner by enabling mypy for backends/arm.

But, choosing to ignore the directory backends/arm/test.

Adding ignores all over the place. These needs to be fixed properly in the future, but now we will start to catch new things trying to sneak in.

Change-Id: Ie7f73d5688aaec3b32dca9f0cd042da94c06f487

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

pytorch-bot · 2025-01-20T12:10:32Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7776

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit aef367d with merge base 58bda89 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

perheld · 2025-01-20T12:12:09Z

@pytorchbot label "topic: not user facing"

perheld · 2025-01-20T12:15:13Z

@pytorchbot label ciflow/trunk

pytorch-bot · 2025-01-20T12:15:18Z

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

pytorch-bot · 2025-01-20T12:16:27Z

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

pytorch-bot · 2025-01-20T14:22:52Z

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

perheld · 2025-01-21T12:55:08Z

Rebased and force pushed. Would like some external review of lintrunner.toml since that is the only file touched outside of backends/arm.

zingo · 2025-01-21T13:02:14Z

@mergennachin here are some mypy include folder changes for you :)

mergennachin

lintrunner.toml file looks good

But in the future, if there are common configs you want to apply across the repo, feel free to modify directly in https://github.com/pytorch/executorch/blob/main/.mypy.ini file

For instance, the tosa serializer could be there.

that way, you don't have to do inline annotations all over

facebook-github-bot · 2025-01-21T20:40:03Z

@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

mergennachin · 2025-01-21T20:41:26Z

Don't merge just yet pls, let me run our internal pyre typechecker first

perheld · 2025-01-21T20:51:52Z

lintrunner.toml file looks good

But in the future, if there are common configs you want to apply across the repo, feel free to modify directly in https://github.com/pytorch/executorch/blob/main/.mypy.ini file

For instance, the tosa serializer could be there.

that way, you don't have to do inline annotations all over

Cool, thanks for the suggestion.

facebook-github-bot · 2025-01-21T22:56:08Z

@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

perheld · 2025-01-22T21:22:57Z

Don't merge just yet pls, let me run our internal pyre typechecker first

Do I need to do anything else to this PR before it can be merged?

perheld · 2025-01-23T16:09:01Z

Did a rebase and fixed merge conflicts. Just small ones. And a new file got added that needed some ignores.

facebook-github-bot · 2025-01-23T16:14:52Z

@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

mergennachin · 2025-01-23T16:15:41Z

Do I need to do anything else to this PR before it can be merged?

Still trying to check something internally first. Our infra setup was broken yesterday, trying again today.

mergennachin · 2025-01-23T16:34:41Z

@perheld - can you rebase this commit on top of the latest commit in main

i still can't import this internally yet

perheld · 2025-01-23T17:21:04Z

Rebased. It's a race now with others doing patches in backends/arm that causes conflicts or adds warnings. 😅

facebook-github-bot · 2025-01-23T18:30:20Z

@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-01-27T22:35:04Z

@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

mergennachin · 2025-01-27T23:41:23Z

Finally was able to import internally. Confirmed internal typechecker is fine.

Please rebase again (and do necessary updates) and merge to main

zingo · 2025-01-28T10:08:17Z

Fail CI jobbs seem very unrelated

zingo · 2025-01-28T14:18:54Z

@mergennachin We get problem with "Meta Internal-Only Changes Check" and it seems we can merge it from Gitbub :(
https://github.com/pytorch/executorch/pull/7776/checks?check_run_id=36271892928

Is this a downside when you test patches internally that they get some "interesting" link between the worlds.

facebook-github-bot · 2025-01-28T16:17:38Z

@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Migration from pyre to mypy in the lintrunner by enabling mypy for backends/arm. But, choosing to ignore the directory backends/arm/test. Adding ignores all over the place. These needs to be fixed properly in the future, but now we will start to catch new things trying to sneak in. Change-Id: Ie7f73d5688aaec3b32dca9f0cd042da94c06f487

zingo · 2025-01-28T18:41:08Z

@mergennachin thanks a lot for the help.

Migration from pyre to mypy in the lintrunner by enabling mypy for backends/arm. But, choosing to ignore the directory backends/arm/test. Adding ignores all over the place. These needs to be fixed properly in the future, but now we will start to catch new things trying to sneak in. Change-Id: Ie7f73d5688aaec3b32dca9f0cd042da94c06f487

Disabling Pyre. Relying on OSS mypy enabled in #7776. Differential Revision: [D70146769](https://our.internmc.facebook.com/intern/diff/D70146769/) [ghstack-poisoned]

Disabling Pyre. Relying on OSS mypy enabled in #7776. Differential Revision: [D70146769](https://our.internmc.facebook.com/intern/diff/D70146769/) ghstack-source-id: 268178737 Pull Request resolved: #8664

Disabling Pyre. Relying on OSS mypy enabled in #7776. Differential Revision: [D70146769](https://our.internmc.facebook.com/intern/diff/D70146769/) ghstack-source-id: 268178737 Pull Request resolved: #8664 --------- Co-authored-by: Digant Desai <[email protected]>

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 20, 2025

pytorch-bot bot added the topic: not user facing label Jan 20, 2025

oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Jan 20, 2025

pytorch-bot bot removed the ciflow/trunk label Jan 20, 2025

perheld marked this pull request as ready for review January 20, 2025 13:18

robell added the ciflow/trunk label Jan 20, 2025

pytorch-bot bot removed the ciflow/trunk label Jan 20, 2025

robell added the ciflow/trunk label Jan 20, 2025

perheld force-pushed the github/ph-MLETORCH-455-mypy-arm-backend branch 2 times, most recently from edfb288 to 59b6ade Compare January 21, 2025 12:52

zingo requested a review from mergennachin January 21, 2025 13:01

perheld force-pushed the github/ph-MLETORCH-455-mypy-arm-backend branch 2 times, most recently from f32537c to fd7207e Compare January 21, 2025 20:07

mergennachin approved these changes Jan 21, 2025

View reviewed changes

mergennachin mentioned this pull request Jan 21, 2025

Enable mypy typechecker tracker #7441

Open

11 tasks

perheld force-pushed the github/ph-MLETORCH-455-mypy-arm-backend branch from fd7207e to 53f72fd Compare January 23, 2025 16:07

perheld force-pushed the github/ph-MLETORCH-455-mypy-arm-backend branch from 53f72fd to 3374ce1 Compare January 23, 2025 17:13

perheld force-pushed the github/ph-MLETORCH-455-mypy-arm-backend branch from 3374ce1 to 3970efa Compare January 23, 2025 17:31

perheld force-pushed the github/ph-MLETORCH-455-mypy-arm-backend branch from 3970efa to d201afe Compare January 28, 2025 07:31

zingo approved these changes Jan 28, 2025

View reviewed changes

mergennachin force-pushed the github/ph-MLETORCH-455-mypy-arm-backend branch from d201afe to aef367d Compare January 28, 2025 16:33

mergennachin merged commit f4786ac into pytorch:main Jan 28, 2025
108 checks passed

perheld deleted the github/ph-MLETORCH-455-mypy-arm-backend branch January 29, 2025 11:34

digantdesai added a commit that referenced this pull request Feb 25, 2025

[ExecuTorch] Arm Ethos: Disable pyre

b79753c

Disabling Pyre. Relying on OSS mypy enabled in #7776. Differential Revision: [D70146769](https://our.internmc.facebook.com/intern/diff/D70146769/) [ghstack-poisoned]

digantdesai mentioned this pull request Feb 25, 2025

[ExecuTorch] Arm Ethos: Disable pyre #8664

Merged

Lintrunner: Enable mypy testing on backends/arm #7776

Lintrunner: Enable mypy testing on backends/arm #7776

Uh oh!

Conversation

perheld commented Jan 20, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7776

✅ No Failures

Uh oh!

perheld commented Jan 20, 2025

Uh oh!

perheld commented Jan 20, 2025

Uh oh!

pytorch-bot bot commented Jan 20, 2025

Uh oh!

pytorch-bot bot commented Jan 20, 2025

Uh oh!

pytorch-bot bot commented Jan 20, 2025

Uh oh!

perheld commented Jan 21, 2025

Uh oh!

zingo commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergennachin left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jan 21, 2025

Uh oh!

mergennachin commented Jan 21, 2025

Uh oh!

perheld commented Jan 21, 2025

Uh oh!

facebook-github-bot commented Jan 21, 2025

Uh oh!

perheld commented Jan 22, 2025

Uh oh!

perheld commented Jan 23, 2025

Uh oh!

facebook-github-bot commented Jan 23, 2025

Uh oh!

mergennachin commented Jan 23, 2025

Uh oh!

mergennachin commented Jan 23, 2025

Uh oh!

perheld commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jan 23, 2025

Uh oh!

facebook-github-bot commented Jan 27, 2025

Uh oh!

mergennachin commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zingo commented Jan 28, 2025

Uh oh!

zingo commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jan 28, 2025

Uh oh!

Uh oh!

zingo commented Jan 28, 2025

Uh oh!

Uh oh!

perheld commented Jan 20, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Jan 20, 2025 •

edited

Loading

zingo commented Jan 21, 2025 •

edited

Loading

perheld commented Jan 23, 2025 •

edited

Loading

mergennachin commented Jan 27, 2025 •

edited

Loading

zingo commented Jan 28, 2025 •

edited

Loading