Do not constant prop for mutable buffers. #7779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7779
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 8f3b834 with merge base 948fba6 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68371513 |
hsharma35
requested review from
cccclai,
angelayi,
tarun292,
mcremon-meta and
dulinriley
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Jan 21, 2025
Summary: Before this change, operations on mutable buffers will be constant prop and replaced with a constant tensor. This change avoids constant prop for mutable buffers. Differential Revision: D68371513
hsharma35
force-pushed
the
export-D68371513
branch
from
46f958d to
38e211f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68371513 |
tarun292
approved these changes
Jan 21, 2025
Summary: Before this change, operations on mutable buffers will be constant prop and replaced with a constant tensor. This change avoids constant prop for mutable buffers. Reviewed By: tarun292 Differential Revision: D68371513
hsharma35
force-pushed
the
export-D68371513
branch
from
38e211f to
8f3b834
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68371513 |
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Differential Revision: D68371513 Pull Request resolved: #7779
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Differential Revision: D68371513 Pull Request resolved: pytorch#7779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Before this change, operations on mutable buffers will be constant prop and replaced with a constant tensor. This change avoids constant prop for mutable buffers.
Differential Revision: D68371513