Skip to content

Cleanup memory passes tests. #7788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

hsharma35
Copy link
Contributor

Differential Revision: D68446633

Copy link

pytorch-bot bot commented Jan 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7788

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 7b157b1 with merge base 4655202 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 21, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68446633

Copy link
Contributor

@mcremon-meta mcremon-meta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup!

@mcremon-meta
Copy link
Contributor

I guess linter is unhappy

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jan 21, 2025
Summary:
Add verifiers for memory allocation.


Reviewed By: zonglinpeng, mcremon-meta

Differential Revision: D68446633
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68446633

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jan 21, 2025
Summary:
Add verifiers for memory allocation.


Reviewed By: zonglinpeng, mcremon-meta

Differential Revision: D68446633
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68446633

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jan 21, 2025
Summary:
Add verifiers for memory allocation.


Reviewed By: zonglinpeng, mcremon-meta

Differential Revision: D68446633
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68446633

Summary:
Add verifiers for memory allocation.


Reviewed By: zonglinpeng, mcremon-meta

Differential Revision: D68446633
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68446633

@facebook-github-bot facebook-github-bot merged commit b3d41f5 into pytorch:main Jan 22, 2025
43 of 47 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
Differential Revision: D68446633

Pull Request resolved: #7788
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
Differential Revision: D68446633

Pull Request resolved: pytorch#7788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants