Skip to content

Qualcomm AI Engine Direct - Update qaihub documentation #7930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

winskuo-quic
Copy link
Collaborator

@winskuo-quic winskuo-quic commented Jan 24, 2025

Summary

cc @mergennachin @byjlw

Copy link

pytorch-bot bot commented Jan 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7930

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 3a790ee with merge base 90a2657 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 24, 2025
@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/update_aihub_documentation branch from c332fe9 to 3a790ee Compare January 24, 2025 06:22
@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
It seems like the documentation for qaihub is unclear, causing community users having difficulty to execute the model. #7550 (comment)
I have updated the documentation, so users know that we need to check QNN version before executing.
Please have a look.
Thanks.

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs!

@@ -62,12 +62,13 @@ python deeplab_v3.py -s <device_serial> -m "SM8550" -b path/to/build-android/ --
```

#### Check context binary version
This is typically useful when users want to run any models under `qaihub_scripts`. When users retrieve context binaries from Qualcomm AI Hub, we need to ensure the QNN SDK used to run the `qaihub_scripts` is the same version as the QNN SDK that Qualcomm AI Hub used to compile the context binaries. To do so, please run the following script to retrieve the JSON file that contains the metadata about the context binary:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we error out with the mismatch version in the runtime? Like, if users load it with the wrong qnn version, errors out.

@cccclai cccclai added module: doc Issues related to documentation, both in docs/ and inlined in code release notes: qualcomm Changes to the Qualcomm backend delegate labels Jan 24, 2025
@cccclai cccclai merged commit e57e6a2 into pytorch:main Jan 24, 2025
45 of 46 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: doc Issues related to documentation, both in docs/ and inlined in code release notes: qualcomm Changes to the Qualcomm backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants