[ET-VK][mac] Allow vulkan binaries to work with Vulkan SDK + fixes to enable debugPrintf extension #7957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enable debugPrintf extension ## Context Add a buck config option to prevent linking against MoltenVK when building for MacOS, instead opting to use volk. This is useful for seeing debug print statments from GLSL code. Also implement some fixes to make things work when using system-installed Vulkan SDK, and some fixes to enable using debug Printf extension on Mac. Specifically, the fixes are as follows: * On newer versions of the Vulkan SDK, a portability instance extension needs to be explicitly enabled, otherwise creating the Vulkan instance will complain about the driver being incompatible. [source](https://stackoverflow.com/questions/58732459/vk-error-incompatible-driver-with-mac-os-and-vulkan-moltenvk) * VkConfig on Mac doesn't show options to enable debugprintf, therefore it has to be enabled programmatically. Differential Revision: [D68650936](https://our.internmc.facebook.com/intern/diff/D68650936/) [ghstack-poisoned]
pytorch-bot
bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7957
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 97bc865 with merge base 1f1a96f ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68650936 |
SS-JIA
added a commit
that referenced
this pull request
Jan 24, 2025
… enable debugPrintf extension ## Context Add a buck config option to prevent linking against MoltenVK when building for MacOS, instead opting to use volk. This is useful for seeing debug print statments from GLSL code. Also implement some fixes to make things work when using system-installed Vulkan SDK, and some fixes to enable using debug Printf extension on Mac. Specifically, the fixes are as follows: * On newer versions of the Vulkan SDK, a portability instance extension needs to be explicitly enabled, otherwise creating the Vulkan instance will complain about the driver being incompatible. [source](https://stackoverflow.com/questions/58732459/vk-error-incompatible-driver-with-mac-os-and-vulkan-moltenvk) * VkConfig on Mac doesn't show options to enable debugprintf, therefore it has to be enabled programmatically. Differential Revision: [D68650936](https://our.internmc.facebook.com/intern/diff/D68650936/) ghstack-source-id: 263006772 Pull Request resolved: #7957
This PR needs a
|
jorgep31415
approved these changes
Jan 27, 2025
trivedivivek
approved these changes
Jan 27, 2025
facebook-github-bot
merged commit e6db67c
into
gh/SS-JIA/173/base
45 of 48 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Jan 27, 2025
… enable debugPrintf extension ## Context Add a buck config option to prevent linking against MoltenVK when building for MacOS, instead opting to use volk. This is useful for seeing debug print statments from GLSL code. Also implement some fixes to make things work when using system-installed Vulkan SDK, and some fixes to enable using debug Printf extension on Mac. Specifically, the fixes are as follows: * On newer versions of the Vulkan SDK, a portability instance extension needs to be explicitly enabled, otherwise creating the Vulkan instance will complain about the driver being incompatible. [source](https://stackoverflow.com/questions/58732459/vk-error-incompatible-driver-with-mac-os-and-vulkan-moltenvk) * VkConfig on Mac doesn't show options to enable debugprintf, therefore it has to be enabled programmatically. Differential Revision: [D68650936](https://our.internmc.facebook.com/intern/diff/D68650936/) ghstack-source-id: 263006772 Pull Request resolved: #7957 Co-authored-by: Stephen Jia <[email protected]>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
… enable debugPrintf extension ## Context Add a buck config option to prevent linking against MoltenVK when building for MacOS, instead opting to use volk. This is useful for seeing debug print statments from GLSL code. Also implement some fixes to make things work when using system-installed Vulkan SDK, and some fixes to enable using debug Printf extension on Mac. Specifically, the fixes are as follows: * On newer versions of the Vulkan SDK, a portability instance extension needs to be explicitly enabled, otherwise creating the Vulkan instance will complain about the driver being incompatible. [source](https://stackoverflow.com/questions/58732459/vk-error-incompatible-driver-with-mac-os-and-vulkan-moltenvk) * VkConfig on Mac doesn't show options to enable debugprintf, therefore it has to be enabled programmatically. Differential Revision: [D68650936](https://our.internmc.facebook.com/intern/diff/D68650936/) ghstack-source-id: 263006772 Pull Request resolved: #7957 Co-authored-by: Stephen Jia <[email protected]>
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
… enable debugPrintf extension ## Context Add a buck config option to prevent linking against MoltenVK when building for MacOS, instead opting to use volk. This is useful for seeing debug print statments from GLSL code. Also implement some fixes to make things work when using system-installed Vulkan SDK, and some fixes to enable using debug Printf extension on Mac. Specifically, the fixes are as follows: * On newer versions of the Vulkan SDK, a portability instance extension needs to be explicitly enabled, otherwise creating the Vulkan instance will complain about the driver being incompatible. [source](https://stackoverflow.com/questions/58732459/vk-error-incompatible-driver-with-mac-os-and-vulkan-moltenvk) * VkConfig on Mac doesn't show options to enable debugprintf, therefore it has to be enabled programmatically. Differential Revision: [D68650936](https://our.internmc.facebook.com/intern/diff/D68650936/) ghstack-source-id: 263006772 Pull Request resolved: pytorch#7957 Co-authored-by: Stephen Jia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
Add a buck config option to prevent linking against MoltenVK when building for MacOS, instead opting to use volk. This is useful for seeing debug print statments from GLSL code.
Also implement some fixes to make things work when using system-installed Vulkan SDK, and some fixes to enable using debug Printf extension on Mac.
Specifically, the fixes are as follows:
Differential Revision: D68650936
cc @manuelcandales