unbreak optimized gelu test #7987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7987
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 36 PendingAs of commit baccacd with merge base da0d85d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
GregoryComer
approved these changes
Jan 28, 2025
|
merging despite unfinished mac unittest because I ran those locally |
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
We don't run optimized gelu in OSS currently (soon, I hope!), so I missed the need to fix it. Test plan: ran optimized gelu test internally.
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
We don't run optimized gelu in OSS currently (soon, I hope!), so I missed the need to fix it. Test plan: ran optimized gelu test internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't run optimized gelu in OSS currently (soon, I hope!), so I missed the need to fix it.
Test plan: ran optimized gelu test internally.