Skip to content

Use TmpTensor for MatMul op. #8088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

trivedivivek
Copy link
Contributor

Summary: This diff introduces the use of temporary tensors to reduce memory usage in the width packed versions of the matmul op shader.

Differential Revision: D68924743

Copy link

pytorch-bot bot commented Jan 31, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8088

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 8ce4553 with merge base baa5ec7 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 31, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68924743

@trivedivivek trivedivivek requested a review from SS-JIA February 3, 2025 22:11
trivedivivek added a commit to trivedivivek/executorch that referenced this pull request Feb 5, 2025
Summary:

This diff introduces the use of temporary tensors to reduce memory usage in the width packed versions of the matmul op shader.

Differential Revision: D68924743
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68924743

Summary:

This diff introduces the use of temporary tensors to reduce memory usage in the width packed versions of the matmul op shader.

Reviewed By: nathanaelsee

Differential Revision: D68924743
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68924743

@facebook-github-bot facebook-github-bot merged commit dad2ba0 into pytorch:main Feb 6, 2025
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants