Skip to content

bump PyTorch nightly to 20250131 #8098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 4, 2025
Merged

bump PyTorch nightly to 20250131 #8098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
acedd13
Update
swolchok Jan 31, 2025
9700e72
Update
swolchok Jan 31, 2025
35d1fb4
Update
swolchok Jan 31, 2025
822f235
Update
swolchok Jan 31, 2025
789b271
Update
swolchok Feb 3, 2025
5f9e0d3
Update
swolchok Feb 3, 2025
444dd52
Update
swolchok Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/docker/ci_commit_pins/pytorch.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0a94bb432ed75cc2d950d81b2921363218a7e459
27e35de6c288bffad1b4d18b393579c1d1a95547
1 change: 1 addition & 0 deletions .ci/docker/conda-env-ci.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
cmake=3.22.1
ninja=1.10.2
libuv
llvm-openmp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one needed given that there is this line to install libomp here https://github.com/pytorch/executorch/blob/main/.ci/docker/common/install_clang.sh#L16?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC @malfet told me to add this one

pkg-config
1 change: 1 addition & 0 deletions .ci/scripts/setup-macos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ setup_macos_env_variables
# NB: we need buck2 in all cases because cmake build also depends on calling
# buck2 atm
install_buck
brew install libomp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok, PyTorch is doing the same thing on MacOS.

install_pip_dependencies

# TODO(huydhn): Unlike our self-hosted runner, GitHub runner doesn't have access
Expand Down
2 changes: 1 addition & 1 deletion backends/arm/test/models/test_conformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class TestConformer(unittest.TestCase):
"executorch_exir_dialects_edge__ops_aten_where_self": 4,
"executorch_exir_dialects_edge__ops_aten_logical_not_default": 4,
"executorch_exir_dialects_edge__ops_aten_any_dim": 2,
"torch.ops.aten._assert_scalar.default": 12,
"torch.ops.aten._assert_scalar.default": 10,
"torch.ops.aten._local_scalar_dense.default": 1,
"torch.ops.aten.scalar_tensor.default": 2,
"torch.ops.higher_order.executorch_call_delegate": 5,
Expand Down
2 changes: 1 addition & 1 deletion backends/arm/test/runner_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def _tosa_dispatch(self, lowered_backend_module: LoweredBackendModule, inputs):
return run_tosa_graph(tosa_buffer, tosa_version, inputs)

def __torch_function__(self, func, types, args=..., kwargs=None):
if isinstance(func, torch._higher_order_ops.executorch_call_delegate.ExecutorchCallDelegate): # type: ignore
if func is torch._higher_order_ops.executorch_call_delegate:
lowered_backend_module = cast(LoweredBackendModule, args[0])
if lowered_backend_module.backend_id == "ArmBackend":
return self._tosa_dispatch(lowered_backend_module, args[1:])
Expand Down
4 changes: 2 additions & 2 deletions install_requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def python_is_compatible():
# NOTE: If a newly-fetched version of the executorch repo changes the value of
# NIGHTLY_VERSION, you should re-run this script to install the necessary
# package versions.
NIGHTLY_VERSION = "dev20250104"
NIGHTLY_VERSION = "dev20250131"


def install_requirements(use_pytorch_nightly):
Expand All @@ -76,7 +76,7 @@ def install_requirements(use_pytorch_nightly):
# Setting use_pytorch_nightly to false to test the pinned PyTorch commit. Note
# that we don't need to set any version number there because they have already
# been installed on CI before this step, so pip won't reinstall them
f"torch==2.6.0.{NIGHTLY_VERSION}" if use_pytorch_nightly else "torch",
f"torch==2.7.0.{NIGHTLY_VERSION}" if use_pytorch_nightly else "torch",
(
f"torchvision==0.22.0.{NIGHTLY_VERSION}"
if use_pytorch_nightly
Expand Down
Loading