Skip to content

Unbrkea some buck builds (tensor_dimension_limit) #8356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

swolchok
Copy link
Contributor

Looks like I forgot to add these deps to a couple targets.

Test Plan: buck2 build //runtime/core/exec_aten/util:
buck2 build //runtime/core/exec_aten/testing_util:

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 11, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Feb 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8356

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 606d7f0 with merge base 9746ce7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 11, 2025
swolchok added a commit that referenced this pull request Feb 11, 2025
Looks like I forgot to add these deps to a couple targets.

Test Plan: buck2 build //runtime/core/exec_aten/util:
buck2 build //runtime/core/exec_aten/testing_util:

ghstack-source-id: fe495b1
ghstack-comment-id: 2649595944
Pull Request resolved: #8356
@swolchok swolchok requested a review from dbort February 11, 2025 01:14
@swolchok swolchok merged commit b751645 into main Feb 11, 2025
45 of 47 checks passed
@swolchok swolchok deleted the gh/swolchok/245/head branch February 11, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants