Skip to content

Enable pybind with mps #8401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Feb 12, 2025

Summary:
install executorch with mps

./install_executorch.sh --pybind mps

test the mps .pte file can run with

executorch_module = _load_for_executorch(filename)
out = executorch_module.forward(list(inputs))

print("output: ", out)

Differential Revision: D69497059

Copy link

pytorch-bot bot commented Feb 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8401

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 3 Pending

As of commit 973ef95 with merge base 89dc36c (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 12, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69497059

Summary:

install executorch with mps
```
./install_executorch.sh --pybind mps
```
test the mps .pte file can run with
```
executorch_module = _load_for_executorch(filename)
out = executorch_module.forward(list(inputs))

print("output: ", out)
```

Reviewed By: shoumikhin

Differential Revision: D69497059
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69497059

@cccclai cccclai added release notes: qualcomm Changes to the Qualcomm backend delegate release notes: apple Changes to the Apple backend delegate and removed release notes: qualcomm Changes to the Qualcomm backend delegate labels Feb 12, 2025
@facebook-github-bot facebook-github-bot merged commit 0beadcc into pytorch:main Feb 12, 2025
46 of 50 checks passed
@swolchok
Copy link
Contributor

swolchok commented Feb 12, 2025

this made lintrunner red: https://github.com/pytorch/executorch/actions/runs/13294401189/job/37122688010

@cccclai
Copy link
Contributor Author

cccclai commented Feb 12, 2025

this made lintrunner red: https://github.com/pytorch/executorch/actions/runs/13294401189/job/37122688010

Oops there was a different lintrunner issue and I didn't realize this pr triggers a new one. Let me fix it.

@cccclai
Copy link
Contributor Author

cccclai commented Feb 12, 2025

#8433 to fix

swolchok pushed a commit that referenced this pull request Feb 12, 2025
#8401 causes lintrunner error and it complains main function too complex. This PR refactors the main function a bit to address the error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: apple Changes to the Apple backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants